Caption reduces image width

Hi there,

Does this occur width or without the caption?

Hi,

I have added a link in my previous message, so you can check this yourself.

Guido

Hi there,

same issue was seen here – see my reply:

https://generate.support/topic/strange-image-sizing-issue-when-caption-text-is-added/#post-75907

Hi David,

Thanks, will try this. But it seems like this is caused by GP, because with other themes this doesn’t occur.

Guido

I done some digging, and its a legacy filter
In the old days of the img_caption_shortcode function in WordPress added 10px to the width of a caption image.

And GP overcame that extra width by removing it here:

https://github.com/tomusborne/generatepress/blob/513d21a557da677cd02f1a82af5f550f2781618c/inc/general.php#L283

Subsequently it looks like WP changed there function that means the added 10px no longer gets applied.

To remedy that, add this snippet to the site to tell GP to NOT remove the 10px.

add_action('wp', function(){
	remove_filter( 'img_caption_shortcode_width', 'generate_remove_caption_padding' );	
});

Hi David,

Many thanks for your investigation. This also means that this function will be removed from GP in the near future?

Guido

If only it were as easy as that ??
We can’t just remove the function as we have backwards compatibility to consider. So we will take under review to see if we can conditionally control it.

For now either the CSS or the PHP Snippet will be required.

Thanks for bringing it to our attention.

• This reply was modified 9 months, 3 weeks ago by David.

Hi David,

Backwards compatibility support should not be forever. Users should move on.. ??

When adding the snippet as Element, which hook should I choose? There’s no effect when choosing wp_head and priority 11.

Guido

This article explains how to add that code:

https://docs.generatepress.com/article/adding-php/

My client has the Elements feature of GP Premium. But it seems now that I cannot use this feature for a snippet like this?

Guido

We cannot answer a question related to premium feature in the free theme support forum here – it’s a WP rule.

I would recommend going with David’s suggestion above.

Hi Leo,

Understood. I will open a topic at the GP Premium forum.

Guido

Thanks! I just answered there ??

@diggeddy / David,

Subsequently it looks like WP changed there function that means the added 10px no longer gets applied.

To remedy that, add this snippet to the site to tell GP to NOT remove the 10px.

Have thought about this some more, but IMO website owners that are using the most recent WP / GP should not be the ones that need a fix for this. If you want to support older WP versions, you could create a fix for that. So not the other way around ??

Guido

As i said, we have it under review.
Once we track down the version where this changed we can look at conditionally loading it.

• This reply was modified 9 months, 3 weeks ago by David.