Can’t find swiper elementor on asset cleanup
-
Hi there,
I’m facing a weird issue that when I test me website on gtmetrix, I see the swiper.min.js of elementor file, but When I check it on your plugin, I can’t find this file as part of the js files of the elementor plugin, no idea why.
Also, What I’m trying to do it to “preload” this file, due to an error I’m getting on speedinsight google tool that saying this file should be preload.
Any help why this is happen? And how can I see this file on asset cleanup plugin?Many thanks.!
-
Hello,
I was glad to read that thread and discover wpacu-preload-elementor-swiper-js. I gave it a try and was happy with it at first. But I soon discovered that my category pages were now slow as hell to load and that it was the culprit.
So i checked why and I’m happy to share an improvement that maybe Gabriel will like.It’s all about being less greedy and more precise when looking for the classes listed in:
$checkIfClassContains = array('swiper-container', 'swiper-wrapper');. And also switching from one preg_match_all to several preg_match (on this one, it could be interesting to make more tests, mostly when all classes are found, I agree…).So here is the original code:
// List all the items from the array separated by | making sure that any RegEx characters with special meaning are quoted via preg_quote() // More information: https://www.php.net/manual/en/function.preg-quote.php $containsListRegEx = implode( '|', array_map( function( $value ) { return preg_quote( $value, '/' ); }, $checkIfClassContains ) ); // This RegEx looks inside a class' content (either within single or double quote) and checks if it has the classes mentioned at $checkIfClassContains $verifyRegEx = '#class=("|\').*('.$containsListRegEx.')(.*?)("|\')(.*?)>#'; preg_match_all($verifyRegEx, $htmlSource, $anyMatches); // Only continue if, all classes where found, continue if (isset($anyMatches[0]) && count($anyMatches[0]) >= count($checkIfClassContains)) {and here is the code I propose:
$anyMatches = 0; foreach ($checkIfClassContains as $checkForThisClass) { // MR: This RegEx looks inside a class' content (either within single or double quote) and checks if it has the class $checkForThisClass $verifyRegEx = '#class=("|\')[^"\']*\b'.$checkForThisClass.'\b[^"\']*?\1#'; if (preg_match($verifyRegEx, $htmlSource)) { $anyMatches++; } else { // MR: Exit as soon as we did not found one of the classes as they are all mandatory break; } } // Only continue if, all classes where found, continue if ($anyMatches && $anyMatches == count($checkIfClassContains)) {According to the class grammar, its content can’t have single or double-quote (not allowed in class names), so specific
[^"\']*should be lighter than greedy.*to match other strings that the one we are looking for. Then I added word boundaries as otherwise regexp could matchmy-own-swiper-container,swiper-wrapper-i-made,this-is-not-a-swipper-wrapper-i-swearclasses or others combinations. I also used a backreference, just to be sure to match the same quote (single or double) that was used to start the content. Finally, I removed the final>as it’s not usefull (we didn’t match the opening one, so why match till the end as we are not sure it’s a matching end?). I also removed the useless grouping parenthesis.In fact, you can keep the original code and change only the regexp and already win a lot of time. For me, original code added around 25s on a category page load time (not having a swiper, so all the HTML is parsed). Adopting the new regexp solved that.
For that, simply replace:
$verifyRegEx = '#class=("|\').*('.$containsListRegEx.')(.*?)("|\')(.*?)>#';
with:
$verifyRegEx = '#class=("|\')[^"|\']*\b'.$containsListRegEx.'\b[^"|\']*?\1#';The switch to
preg_matchallows to stop the search sooner on a page if no match is found on a class. But there is still a need to check the real efficience of that!Anyway, I thank you Gabriel for this piece of code.
- The topic ‘Can’t find swiper elementor on asset cleanup’ is closed to new replies.
