Can’t delete slides (no final effect) in WP 4.7 using v3.4

Hi there,

It might be that a JavaScript error is preventing the deleted slide from being removed fully.

Without deactivating the other plugins the other method diagnosis would be to view the errors after a slide is deleted (or after the button is clicked).

Can you use Chrome’s console to inspect the errors and let me know what you see?
https://developers.google.com/web/tools/chrome-devtools/console/

This can happen if there is a large amount of slides – perhaps you could check if the same thing happens on a brand new slideshow?

Thanks,
Dave

No errors in console itself, as in inspecting ajax through network tab admin-post.php?action=metaslider_delete_slide&slider_id=1739&slide_id=1736&_wpnonce=f5b59d7611 redirects 302: admin.php?page=metaslider&id=173

There are 6 active sliders with aprox. 4slides per slider.

It does not seem to happen on newly created slider.

Also I’ve noticed you are just trashing the slides? Is there a way how to remove them completely?

Also I’ve noticed there are actually no posts of type “ml-slide”, altough sliders have slides and work, I guess you are storing the info as some sort of meta values ? ??

• This reply was modified 8 years, 2 months ago by jave.web.
• This reply was modified 8 years, 2 months ago by jave.web.

Can this happen when 1 slide (image) is actually used in more sliders?

So it’s not due to the amount of slides then as you don’t have many.

You can delete the slides (custom post type) by viewing the post type index:
/wp-admin/edit.php?post_type=ml-slider

But you’ll need to add the following filter to your theme’s functions.php file first:

add_filter( 'register_post_type_args', 'ml_slider_show_ui', 10, 2);

function ml_slider_show_ui ( $args, $post_type ) {

  if ( 'ml-slider' === $post_type ) {
      $args['show_ui'] = true;
  }

  return $args;
}

You’re correct in that a slider doesn’t make use of an actual post in the conventional sense but there is one post per slideshow.

I’m not sure what’s causing the the deleting issue still sorry but perhaps it’s due to the existing content in the sliders, sometimes the data can become corrupt through migrations.

Thanks,
Dave

I belive that what you have just posted regards slideRs not slides ?? I’ve also noticed you are preparing new format of slides which will be one slide = one post – when is this coming please ? ??

Thanks for the migration tip, but I am not able to evaluate that now.

• This reply was modified 8 years, 2 months ago by jave.web.

Yes, sorry, the above is regarding sliders. To remove individual slides completely would need to be done directly with the database which is not advised.

We’re unable to provide a timeline for specific updates at this point I’m afraid but keep checking back.

Thanks,
Dave

Hi Jave,

Just to fill you in on how it works at the moment (and still in 3.4).

When you add a slide to a slideshow, the media file itself is tagged to a taxonomy term which is the ID of the slider. When we delete a slide, we just remove that relationship, we don’t delete the media file itself (as it may be being used elsewhere on your site).

To fully delete a slide, right now, all you would do is delete the media file.

In the upcoming updates (as you’ve found), we’re going to be storing new slides as a new post type, therefore removing the 1:1 relationship between media file and slideshow.

However, that functionality is not live yet, but most of the code is in place. We’ll be trashing slides (rather than fully deleting) so that we can give users the option to ‘undo’. Slides could be fully deleted by adding code similar to what Dave has posted above, which will reveal the post type interface and you will be able to “permanently delete” your trashed slides (we’ll provide details on that once it’s released).

Regards,
Tom

Hi, this is some very useful info and good idea to give user free hands, thank you ! ??

Altough I am still wondering how are you storing settings per slide (in current state) ??

BTW: The problem was hot-fix-like solved by recreating the slider, in newly created one it seems everything works properly.

Hi Jave,

The caption is stored in the excerpt field, the other data is stored as post meta. This won’t change in the future, the only thing that will change is that we’ll save the data against new posts, rather than to the media file itself.

Regards,
Tom