Cannot add a new field

i can confirm that.

currenty im exporting/importing the json to add fields. but i don’t know how a table field should look like.

Ok i fixed it in my instance.

the problem is inside the JS construction at `/just-custom-fields/assets/just_custom_fields.js

before there was the old live function for the submit event handler of the “edit field” form. it took care of elements with the same selector to be attached to the event handler even if its created after the attachment (by an ajax call) which is the case here.

i encapsuled the event handler in a new seperate function jcf_init_edit_field apart from initFieldsetFields and added it to the promise handler of the ajax response jcf_show_ajax_container

i will make a pull request on github and share the changed code when its ready.

• This reply was modified 4 years, 1 month ago by netzgestaltung.

I made a pull request for that, compare the changes: https://github.com/aprokopenko/justcustomfields/pull/96/files

the (temporary) fixed file: https://github.com/netzgestaltung/justcustomfields/blob/netzgestaltung-patch-edit-field-js/assets/just_custom_fields.js

please be aware that updates will overwrite your changes in plugin files.

Thank you very much for your work, we will check it and release a hotfix

I also encountered more errors

when adding a collection field inside there is another “add” button that does not work.

also on editing related content in posts in the block editor (i also quick-fixed that one with another PR)

you need to check every “.on” function if the preceding selector selects an element that is added to the DOM later in time.

br
tom

• This reply was modified 4 years, 1 month ago by netzgestaltung.

Hi there,
just a short reminder that the pull requests are still open ??
kind regards
tom