Calendar 6.5.1 problem with styling after update
-
Plugin after update has problem with styling, styling missing in settings page and in event pages, paths for files are not correct, missing slash between WP folders. This happens in Wampserver. https://ibb.co/1v2dSf5
-
So I have been able to fix all the 404s to non minified js/css files.
There is an issue with maybe_get_min_file function in \the-events-calendar\common\vendor\vendor-prefixed\stellarwp\assets\src\Assets\Asset.php
it clearly expects $url being passed in to be a relative url not absolute. In my case they are all absolute so to fix this you need to change:if ( 0 === strpos( $url, $wpmu_plugin_url ) ) {
// URL inside WPMU plugin dir.
$base_dir = $base_dirs[ WPMU_PLUGIN_DIR ];
$base_url = $wpmu_plugin_url;
} elseif ( 0 === strpos( $url, $wp_plugin_url ) ) {
// URL inside WP plugin dir.
$base_dir = $base_dirs[ WP_PLUGIN_DIR ];
$base_url = $wp_plugin_url;
} elseif ( 0 === strpos( $url, $wp_content_url ) ) {
// URL inside WP content dir.
$base_dir = $base_dirs[ WP_CONTENT_DIR ];
$base_url = $wp_content_url;
} elseif ( 0 === strpos( $url, $plugins_url ) ) {
$base_dir = $base_dirs[ WP_PLUGIN_DIR ];
$base_url = $plugins_url;
} else {
// Resource needs to be inside wp-content or a plugins dir.
return false;
}to
if ( false !== strpos( $url, $wpmu_plugin_url ) ) {
// URL inside WPMU plugin dir.
$base_dir = $base_dirs[ WPMU_PLUGIN_DIR ];
$base_url = $wpmu_plugin_url;
} elseif ( false !== strpos( $url, $wp_plugin_url ) ) {
// URL inside WP plugin dir.
$base_dir = $base_dirs[ WP_PLUGIN_DIR ];
$base_url = $wp_plugin_url;
} elseif ( false !== strpos( $url, $wp_content_url ) ) {
// URL inside WP content dir.
$base_dir = $base_dirs[ WP_CONTENT_DIR ];
$base_url = $wp_content_url;
} elseif ( false !== strpos( $url, $plugins_url ) ) {
$base_dir = $base_dirs[ WP_PLUGIN_DIR ];
$base_url = $plugins_url;
} elseif ( false !== strpos( $url, $stylesheet_url ) ) {
$base_dir = $base_dirs[ $stylesheet_dir ];
$base_url = $stylesheet_url;
} else {
// Resource needs to be inside wp-content or a plugins dir.
return false;
}then this:
$relative_location = str_replace( $base_url . ‘/’, ”, $url );
needs to be change to
$relative_location = substr($url, strpos($url,$base_url) + strlen($base_url) + 1);
That has fixed all of the 404s we were getting. I don’t understand why you would use the non minified paths to declare your assets then rely on this function to use the minified path if it exists when the non minified path doesn’t exist in the first place. It seems crazy to do this. If you wanted a dev environment wouldn’t you just remove .min and check if that exists instead of the other way around.
This still hasn’t fixed all of my issues.When logged in the response is fine but when not logged in I get a completely blank response.
There is nothing in php logs. I will continue trying to debug the plugin, if I can fix it I will post my bugfix here.
- The topic ‘Calendar 6.5.1 problem with styling after update’ is closed to new replies.
