Button labels not directly updated and missing translations

  • Resolved ldwd

    (@ldwd)


    1 year, 2 months ago

    Hi,

    First, I didn’t get a notice that the statuses had been removed from the Publish Planner plugin. Two days after updating I just wanted to check the slug of a custom status when I noticed that statuses were gone and are now in a separate plugin. A heads up would have been nice (although I read that others did see a one time message).

    Second, after installing the new plugin, the Save buttons don’t behave the same way anymore. I’m using a custom post type with the classic editor. Earlier when I selected a custom status and clicked OK, the button above showed the status name prepend by Save as. Now it reads Save as Draft by default for every custom status. Only after clicking that button the button text changes to the one set in Save as Label in the new plugin’s settings. I need it to read that right after clicking OK, just like it did before.

    –

    (The button reads Concept opslaan which is Dutch for Save as draft.)

    Third, default statuses are not translated when viewed in the editor’s dropdown (Quick Edit does show translated). Not even when using a translation plugin like Loco Translate.

    I tested on two sites with the same results.
    Any help is much appreciated. Thank you!

    • This topic was modified 1 year, 2 months ago by ldwd.
    • This topic was modified 1 year, 2 months ago by ldwd.
    • This topic was modified 1 year, 2 months ago by ldwd.
Viewing 10 replies - 1 through 10 (of 10 total)

  • Similiar here with Turkish translations added via Loco.

    And also another or same problem for the default submit button.

    Plugin Author Kevin Behrens

    (@kevinb)

    @ldwd @gokcer We just released Statuses 1.0.4 to fix the language and Classic Editor issues.

    I saw the same issues, and chased them all down. Please re-test with the new version and see if you agree it’s working quite well now.

    Plugin Author Kevin Behrens

    (@kevinb)

    @ldwd @gokcer If you still have some status captions untranslated, take a look at Statuses > Settings. There is a new setting for Status Label Customization, to specify which statuses should use non-default captions saved on the Labels tab of Status properties. Set to “user-created statuses only” to prevent conflict with translation files / Loco.

    Thread Starter ldwd

    (@ldwd)

    Hi @kevinb, thank you for your quick response!

    The translations are working now!
    Unfortunately, the button text still reads Save as draft.

    With the new setting for Status Label Customization set on For all plugin statusses, the Label tab on my custom status is not visible, is that correct behaviour? Only when set to For user-created plugin statuses only the label tab appears. I find that confusing.

    Btw, even when the label tab is not there, the value is still shown in the editor.

    Plugin Author Kevin Behrens

    (@kevinb)

    @ldwd Yes, it means labels stored along with plugin settings will override your language file only for user-created statuses. But I need to follow up with one more update to further limit the stored label usage so that plugin-stored captions will always be disregarded if they are identical to defaults.

    Thread Starter ldwd

    (@ldwd)

    @kevinb, I’m not sure what you mean with your comment.

    My confusion is that when the option is set to For all plugin statusses I expect the label tab to be displayed on ALL statuses. But it’s not: it’s displayed at Pending Review, but not on the custom one.

    –

    Switching to For user-created plugin statuses only will make it the other way around:
    Pending Review -> no label tab
    Custom status -> label tab
    (which IS expected behaviour).

    And do you have any update on the buttons still showing Save as Draft in the classic editor?

    Thank you!

    Plugin Author Kevin Behrens

    (@kevinb)

    @ldwd Can you please try again with Statuses 4.0.1?

    I confirmed and fixed the issue of the Labels tab not displaying for plugin-defined statuses.

    I was never able to replicate the issue of the Save As button showing a translated “Save as Draft” after any status selection. This version has some other Classic Editor fixes, though, so it could possibly clear this up. If not, I might need more details on how to imitate your setup.

    Thread Starter ldwd

    (@ldwd)

    @kevinb, thank you for your hard work.

    Yes the Label tab is now displayed correctly!

    The update to 1.0.4.1 didn’t change anything about the Save As button, BUT I discovered that changing the Gutenberg/Classic Editor option from Automatic to Classic Editor did the trick!

    I didn’t think of this before because the statuses themselves were loaded in the dropdown, so I left it as it was. Now I just tried everything and this solves the problem (again, I use a custom post type which uses the classic editor).

    Testing on two sites I can confirm changing this setting also works in the previous version (1.0.4).

    Thank you for all your help!

    Plugin Author Kevin Behrens

    (@kevinb)

    @ldwd Oh, I’m glad to hear that. Thanks for following up.

    Thread Starter ldwd

    (@ldwd)

    @kevinb, just fyi: after updating to 1.0.5 I can safely set the Gutenberg / Classic Editor option back to Automatic. The Save As button now shows the correct status name ??

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Button labels not directly updated and missing translations’ is closed to new replies.