bugs of fsthickboxannouncement

you are right, i allready realized the missfunction of the date option. i’m fixing this and i’m going to use a javascript calendar control, so the date can be picked instead of entered manually…

why do you need an iframe option? use external url instead. i will rename this to external content or something similar to make it clear.

cheers mate and thx

i have tried… but without luck so i use it as iframe =).

cheers.

you’re are right. in the front an external resource does not appear. i provided an update which fixed this and the other stuff…

hi Fabien =).

nice to more fixes =) i hope you will understand what this code mean course i am a bit tierd after work.. and just fix that code.

if ($tb_show_type == 3) {
			$exp = 0; // Show every time the user enters the site
		} else {
			$exp = time()+self::DAY_IN_SECONDS*360; // Expires after a year
		}

		if (!isset($_COOKIE['tb_cookie']) || $_COOKIE['tb_cookie'] != get_option('tb_cookie')) {
			if ($tb_show_type == 1) { // Show only once (per Session)

				setcookie('tb_cookie', get_option('tb_cookie'), $exp);
				setcookie('tb_lastshown', time(), $exp);
				$this->showAnnouncement = true;				

			} elseif ($tb_show_type == 2) { // More than once, check frequency

				$days = intval(get_option('tb_show_freq'));

				if ($days > 0) {
					// Get beginning of the day, when it should be displayed again
					$aexp = floor(($_COOKIE['tb_lastshown'] + $days*self::DAY_IN_SECONDS) / self::DAY_IN_SECONDS) * self::DAY_IN_SECONDS + 1;

					if (time() < $aexp){

						setcookie('tb_cookie', get_option('tb_cookie'), $exp);
						setcookie('tb_lastshown', time(), $exp);
						$this->showAnnouncement = true;									

					}
					return;
				}
			} else {
				// case 3 - always!
				$this->showAnnouncement = true;
			}
		}

		// If cookie is not set, allways show announcement. this condition is given by
		// only doing the checks if the current cookie string is equivalent

		// Turn Announcement on

		return;
	}

hi

thanks for your input. i don’t think your code is correct, but mine is not either…

the right condition is:

if the COOKIE does not exist, allways display (no dependence on show type)
if the COOKIE string is NOT equivalent, allways display (no depence on show type).

if the COOKIE string IS equivalent, the announcement must only be displayed, if the show_type is 2 (periodically) and the time must be expired.

conclusion:

// If cookie is set AND cookie string is identical, then only show when
		// in frequency mode!
		if (isset($_COOKIE['tb_cookie']) && $_COOKIE['tb_cookie'] == get_option('tb_cookie')) {
			// Show only once per session
			if ($tb_show_type == 1) {
				return;
			// Show every time the user enters the site
			// This is achieved by setting the cookie expiration to 0
			} elseif ($tb_show_type == 3) {
				return;
			} elseif ($tb_show_type == 2) { // More than once, check frequency
				$days = intval(get_option('tb_show_freq'));

				if ($days > 0) {
					// Get beginning of the day, when it should be displayed again
					$aexp = floor(($_COOKIE['tb_lastshown'] + $days*self::DAY_IN_SECONDS) / self::DAY_IN_SECONDS) * self::DAY_IN_SECONDS + 1;

					if (time() < $aexp)
						return;
				}
			}
		}
		else {
			// Allways display
		}

		if ($tb_show_type == 3) {
			$exp = 0; // Show every time the user enters the site
		} else {
			$exp = time()+self::DAY_IN_SECONDS*360; // Expires after a year
		}

		setcookie('tb_cookie', get_option('tb_cookie'), $exp);
		setcookie('tb_lastshown', time(), $exp);

		// Check announcement page
		$this->checkInternalContentPage();

		// Turn Announcement on
		$this->showAnnouncement = true;
		return;

I think, this should work for any cases. Do you agree?

In your FAQ at worpress.org it says:

I have set-up an announcement, but no announcement is displayed

Both hooks wp_head and wp_footer are being used. Check your template for the call of wp_head() and wp_footer().

What should we do from that point?

Thanks… yes, i am basic at php code…