Bugs Found

  • Resolved Kimberly

    (@kellogg9)


    9 years, 5 months ago

    header.php:

    the arial-controls value of “menu” is wrong.
    <button class="menu-toggle navbar-toggle" aria-controls="menu" aria-expanded="false">

    It should be “menu-main“:
    <button class="menu-toggle navbar-toggle" aria-controls="menu-main" aria-expanded="false">

    searchform.php:

    the value=”” is not needed, should be removed and the alt=”” attribute is missing (causes an html5 validation error without it):
    <input type="image" src="<?php echo get_template_directory_uri(); ?>/images/search-button.png" value="" id="search-button">

    should be replaced with:
    <input type="image" src="<?php echo get_template_directory_uri(); ?>/images/search-button.png" alt="Search" id="search-button">

    style.css:

    3 rule areas in style.css you refer to a non-existent class commentlist which is a clear mistype and should be comment-list

Viewing 5 replies - 1 through 5 (of 5 total)

  • Hi Kimberly,

    Nice catch, will fix it on our next update.

    Thanks

    Hi Kimberly,

    Sorry but can you please justify why you saying that the code below is wrong.
    <button class="menu-toggle navbar-toggle" aria-controls="menu" aria-expanded="false">

    I’ve been researching about aria-controls and I can’t figure-out why you said it wrong.

    thanks

    Thread Starter Kimberly

    (@kellogg9)

    Hi Mark! Not a prob! ?? I was using the online W3 Validation tool and it detected aria-controls=”menu” as an error because it thinks “menu” does not exist despite it clearly being indicated as a class attribute on <ul class=”menu nav-menu” id=”menu-main”>. So, when i changed the aria-controls value from “menu” to “menu-main” which is simply the id value for that same line (instead of the class name which u used) it finally validated fine. Does the aria-controls attribute insist on id’s only? Maybe the W3 validator is mistaken.

    Hope that helps.

    Regards

    Hi Kimberly,

    Thank you for a nice catch on all issues on W3 validation, it’s all fixed now and ZERO error. ??

    Also I fully understand the purpose on aria-controls, the aria-controls value should be match on the
    <ul> id.

    The new WP Fanzone 2.3 is now uploaded. Hope you will enjoy by using this once it will available for download

    Thanks

    Thread Starter Kimberly

    (@kellogg9)

    You’re AMAZING! Thanks Mark!!!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Bugs Found’ is closed to new replies.