Bugfix suggestion in Join.php

  • Hi,

    We had a bug in ACF Better Search plugin due to non-sequential post_meta ids and this part of SQL query in app/Search/Join.php :

    'INNER JOIN %s AS b ON ((b.meta_id = a.meta_id + @@auto_increment_increment) AND (b.post_id = %s.ID))',

    We were able to solve this by replacing this line with this working code :

    'INNER JOIN %s AS b ON ((b.meta_key = "_"+a.meta_key) AND (b.post_id = %s.ID))',

    Could this bugfix be reviewed and included in the next release ?

    Thank you in advance

Viewing 1 replies (of 1 total)
  • Plugin Author Mateusz Gbiorczyk

    (@mateuszgbiorczyk)

    Hi @inovagora,

    Thank you for your message. Thank you also for the suggestion of change.

    I thought about this solution a long time ago. Unfortunately, with more data in the database, the query time is 2.5 times longer than the query in which we use meta_id.

    Therefore, I can’t make this change to the plugin. I think you understand why.

Viewing 1 replies (of 1 total)
  • The topic ‘Bugfix suggestion in Join.php’ is closed to new replies.