BUG: Player able to bet after game closing time.

Thanks for reporting. Will test and get back to you.

Thanks for the response.. I was debating on buying this plugin but was worried it wont get updated or bugs closed in the future. Since you are around I will most likely be buying this plugin. I really would like to see the bug closed and maybe an option for admin to see all currently open bets in admin panel..

Also would it be hard to change the game menu from expanding bars to maybe just dot selection similar to betonline.ag sportsbook menu?

I tried to reproduce the bug but I couldn’t. The system is working as expected and is responding with the appropriate error messages. I tried both to add a bet option after its event is expired & submitting the slip with a bet option of expired bet event but the system didn’t let me in both cases.

Are you sure that the event was expired at the time you submitted the slip? Please double check the timezones and the “Close bets earlier” option. Also, open another tab with the betpress_bettings shortcode and make sure the event you bet on is not listed there (this way you will be sure it is expired).

As for your “worries” – they are actually true, most probably the plugin won’t be updated anytime soon. So buy the full version only if you are happy with the features it currently provide.

Well I tried it on my iPhone. First I picked a game and added it to my bet slip and waited until the game no longer showed on the list. I waited 5 mins after the game was started and the game no longer on the list.

That is very weird because I am sure the game was closed because it was removed from the main list. I didn’t get any error when submitting the bet slip after the game was closed. All it said was bet success.

You might want to keep trying it. Put like 2-3 games in your bet slip and wait for the games to close before you submit it.

Well, I couldn’t reproduce the problem. I tried everything I could think of and still the system is working as expected.

Did you tried again after I replied to you? As I told you I am almost sure you didn’t consider the timezone and the “close bets earlier” option. Also, there is a big chance you submit the slip in on of the latest possible seconds and you couldn’t see the game in the list because by the time you opened the new page the system closed the game. So please try this using a PC and open two tabs (the code is not affected by the device so the problem could not be on mobile devices only).

Also, if you reproduce it again, please record it so I can take a look, too. I know I ask too much but that’s the only way for me to see what’s going on.

After my tests, I am even more confident that there is no such issue tho, and I will be really surprised if I can see a record of this issue.

Did you use two different devices? I know for sure its not a problem with time zone because the game is taken off the featured/games list.

I don’t think you’re doing the bug right.

1. Open and set a game for 5 mins.
2. Using an iPhone load the selected game into the bet slip.
3. Wait for game to close and taken off the featured or games list.
4. Wait 5 more minutes to make sure, then input amount and submit bet slip.

I am really sure this is a bug because I don’t think you have a code to reject late bets.

You have to pre-load the bet selection into a bet slip before the game closed and be removed from featured/games list.

• This reply was modified 8 years, 3 months ago by rookieplugin99.

Of course there is a code to check for expired games when the slip is submitted. Quoting you lines 37-54 from /controllers/submit-slip.php from the BetPress Lite version:

   //check for passed deadline
            foreach ($bet_options_ids as $bet_option_ID => $bet_option_odd) {

                $bet_option_details = betpress_get_bet_option($bet_option_ID);

                $seconds_to_close_bets_earlier = (int) get_option('bp_close_bets');

                $bet_event_close_time = $bet_option_details['deadline'] - $seconds_to_close_bets_earlier;
                
                if ($bet_event_close_time < time()) {
                    
                    $errors [$bet_option_details['bet_event_name']] = sprintf(
                            __('The deadline for %s has passed.', 'BetPress'),
                            $bet_option_details['bet_event_name']
                        );
                    
                }
            }

To check and test the code was the first thing I did after you reported the problem. There is also a similar check when you add bet option to your slip which I also checked and is working.

Here is the photo of the bug… after the first bet I made I checked the games listing on my computer and the game was removed from the list but it was not removed from my iPhone which allowed me to submit the 2nd on through the iPhone.

I had the game time closing set for 21:50 and close 30 seconds before game start in settings.

View post on imgur.com

This may be a glitch through the iPhone because it didn’t seem to refresh game list on the iPhone after the game was removed when I checked my computer.

The next thing we could try to zero this down is if you make a game on the demo site and allow me to try and make a late bet.

From what I understand from your reply with the screens – the games are expired when you refresh the page on your desktop device but they are still not expired after a refresh on your mobile device? If that’s true, there is only one reason for this to happen – your mobile device’s browser cache. But even if that’s the case, the system will still make the needed check and reject to add the bet option and/or submit the slip.

You are free to play around with the demo tho, there are admin credentials publicly available.

Do you know how to enable the error logger, reproduce the problem and send me the log file so I can see if there are any errors produced? I believe there is something weird that is happenning specifically on your environment with your data and that’s why I cant reproduce it.

I have to admit that I can see few things that may cause problems from the code I’ve quoted above tho.