Bug: module not rendering when "type" setting used

Hey Oliver,

I just tested this by adding a type field to one of the builtin modules and it worked fine. Can you double check to make sure you don’t have another field with the id of “type” somewhere else in the form?

Justin

Hmmmmm. I’ve triple checked everything, there is no type field ID anywhere else in the form fields.

I’ve gone ahead and tried this on the HTML module included with Beaver Builder Lite Version.

I’ve changed the beaver-builder-lite-version/modules/html/html.php file to:

<?php

/**
 * @class FLHtmlModule
 */
class FLHtmlModule extends FLBuilderModule {

  /**
   * @method __construct
   */
  public function __construct()
  {
    parent::__construct(array(
      'name'     => __('HTML', 'fl-builder'),
      'description'  => __('Display raw HTML code.', 'fl-builder'),
      'category'		=> __('Advanced Modules', 'fl-builder')
    ));
  }
}

/**
 * Register the module and its form settings.
 */
FLBuilder::register_module('FLHtmlModule', array(
  'general'    => array(
    'title'     => __('General', 'fl-builder'),
    'sections'   => array(
      'general'    => array(
        'title'     => '',
        'fields'    => array(

          'type' => array(
            'type'  => 'text',
            'label' => 'Type testing',
          ),

          'html'     => array(
            'type'     => 'code',
            'editor'		=> 'html',
            'label'     => '',
            'rows'     => '18',
            'preview'      => array(
              'type'       => 'text',
              'selector'     => '.fl-html'
            )
          )
        )
      )
    )
  )
));

and also the beaver-builder-lite-version/modules/html/includes/frontend.php file to:

<div class="fl-html">
  <?php echo $settings->type . ' ...and the actual HTML contnet: ' . $settings->html; ?>
</div>

Resulting to: https://vimeo.com/116800143 (password is: bbbug)

Can you please check on your side?

Thanks.

Oliver

Hey Oliver,

I reviewed the code for this and it looks like the $settings->type property is reserved by the module to store its type (e.g. heading, rich-text, photo). Can you use another id for that field?

Justin

Hi Justin,

Yes, I’ve done this already. I’ve added an additional parameter to my shortcodes which then translates to the original “type” parameter. This solution doesn’t seem very OK to me…

So there is no chance I can use a “type” field ID/name in Beaver Builder and this can not be resolved?

Thank you for your help!

Regards,

Oliver

Hey Oliver,

The reason modules already have a type parameter in their settings object is because they also have a type parameter on the main object.

The reason for that is because modules are “nodes” just as rows, column-groups and columns are. Nodes all have the same internal structure so they can be acted upon using a common set of methods. In many of those methods, we need to know what type of node we are working on, that’s why we have the $node->type parameter.

Modules are a bit different as there can be many types of modules, as opposed to the others where there is only one type. As such, we are storing the type of module in the settings object so we can differentiate between them. It’s not stored on the main object to keep the structure consistent with other nodes.

If you unserialize the _fl_builder_data post meta you may get a better understanding of the builder’s data structure.

I hope that makes sense!

Thanks,
Justin

Hi Justin,

Thank you for the explanation!

I’ve went ahead and actually rebuilt my shortcodes that used “type” parameter to rename it to something more suitable. Hopefully there will be no conflict with this parameter names for the other plugins in the future ??

Thanks again. Considering this as resolved.

Regards,

Oliver