Bug in download url

  • Resolved marsjaninzmarsa

    (@marsjaninzmarsa)


    3 years, 4 months ago

    Hi, in your plugin in shortcodes.php:527 you have following code:

    
$download_url = home_url() . '/?file=' . rawurlencode( $file ) . '&nonce=' . rawurlencode( $nonce ) . '&email=' . rawurlencode( $values['email'] );

    which causes generated link to be inaccessible in some clients – all & in hrefs should be encoded as entities – meaning &s instead of &.

    Here you have the correct code, tested to be working:

    
$download_url = home_url() . '/?file=' . rawurlencode( $file ) . '&nonce=' . rawurlencode( $nonce ) . '&email=' . rawurlencode( $values['email'] );
    • This topic was modified 3 years, 4 months ago by marsjaninzmarsa. Reason: amps
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author mkscripts

    (@mkscripts)

    Hi,

    Thank you for noticing! We will change it in the following update.

    Kind regards,
    Team Download After Email

    Plugin Author mkscripts

    (@mkscripts)

    This issue has been resolved with the update to version 2.1.3.

    Kind regards,
    Team Download After Email

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Bug in download url’ is closed to new replies.