Bug/enhancement function swcfpc_adjust_internal_links

  • Resolved harryfear

    (@harryfear)


    1 year, 11 months ago

    Can you kindly ensure this JS function is only declared if it doesn’t already exist?

    function swcfpc_adjust_internal_links( selectors_txt ) {

    Can be:

    var swcfpc_adjust_internal_links = function( selectors_txt ) {

    Because there is a compatibility issue with the Oxygen Page builder.

    https://ibb.co/PDM8XWS

Viewing 11 replies - 1 through 11 (of 11 total)
  • Thread Starter harryfear

    (@harryfear)

    This is with regard to:

    wp-cloudflare-page-cache/libs/cache_controller.class.php

    Thread Starter harryfear

    (@harryfear)

    Apparently also need this fix:

    var swcfpc_wordpress_btn_publish = document.querySelector(".editor-post-publish-button__button");

    Rather than a const

    Plugin Contributor iSaumya

    (@isaumya)

    Hi @harryfear,
    Thanks for reporting this. This is happening cause the Oxygen Builder is running the same code twice when the code is supposed to be part of the page once.

    Thought I HATE using var in JavaScript and always stick with either let or const, but due to the fact that Oxygen Builder is running the same code twice and they have no intention to fix their code, there is no other way but to use the disgusting var.

    Anyways, I’ve implemented the fix you mentioned above and you can download the current dev build of the plugin from here. Please download it and test it. Let me know if this resolves the issue or not and also if every feature of this plugin is working as it should.

    Thread Starter harryfear

    (@harryfear)

    Hey Saumya,

    Love your work!

    Checked the updated plugin and I can confirm it works perfectly. Thank you!

    Will this go into a new minor release at some point?

    Plugin Contributor iSaumya

    (@isaumya)

    Hi @harryfear,
    Yes once I have a few things together will release the minor update.
    But still hate using var. It’s like I’m crying while typing this code.

    Thread Starter harryfear

    (@harryfear)

    I get your pain!

    Plugin Contributor iSaumya

    (@isaumya)

    Thanks. If you haven’t already please consider sharing a review in the review section of the plugin.

    Thread Starter harryfear

    (@harryfear)

    This isn’t live yet, right?

    Plugin Contributor iSaumya

    (@isaumya)

    Hi, no it isn’t live yet. Will push an update soon.

    Thread Starter harryfear

    (@harryfear)

    Pardon me; is this live now?

    Plugin Contributor iSaumya

    (@isaumya)

    Yes it is.

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Bug/enhancement function swcfpc_adjust_internal_links’ is closed to new replies.