[BUG] Database error when installing plugin (take 2)

As I see, this error does not occur only when plugin is installed but on every scan call or cron check.

And in performance_schema, in x$statements_with_errors_or_warnings, I see lots of warnings with queries on wp_wf* tables.

Hi @dsmidgy

Thanks for reaching out!

Unfortunately, you will still see these flags, even though there is no actual issue there.

Rest assured that nothing is breaking, just plugins like QueryMonitoring are revealing hidden error codes.

Thanks,

Joshua

Let’s say you have lots of databases with lots of applications written this way – that errors are risen when the isn’t an actual problem. You get tons of errors per day and you have to analyze them each day to see which of them are not actually errors.
If there is no problem, the error should not be raised. It would only be excusable when a external library is used over which developer has no control of.

I fixed the the code in wfCongif.php that handles this insert/update. But I am not a php/wp developer and the changes below are not tested. But this should insert 1 is there is no row present or increment the existing value by 1 and return this updated value.

public static function atomicInc($key) {
	if (!self::$tableExists) {
		return false;
	}
	
	global $wpdb;
	$table = self::table();
	$result = $wpdb->get_results($wpdb->prepare("INSERT INTO {$table} (name, val, autoload) VALUES (%s, %s, %s) ON DUPLICATE KEY UPDATE val = @new_val := val + 1; SELECT @new_val AS new_val;", $key, 1, self::DONT_AUTOLOAD));
	
	if (count($result) == 1) {
		return $result[0]->new_val;
	}
	return 1;
}

The SQL code looks like this.

INSERT INTO wp_wfconfig (name, val, autoload) VALUES ('lastNotificationID', 1, 'no') ON DUPLICATE KEY UPDATE val = @new_val := val + 1; SELECT @new_val AS new_val;

• This reply was modified 1 year, 12 months ago by DSmidge.
• This reply was modified 1 year, 12 months ago by DSmidge.

Hi @dsmidgy

Thanks for the feedback!

Glad to hear that you were able to find a workaround.

We are unable to support custom code changes involving the Wordfence plugin, but we thank you for showing this!

Best,

Joshua