Bug after update to 1.8.3

  • Resolved getupworks

    (@getupworks)


    6 years, 10 months ago

    hey there,
    thanks for this great plugin which i use with most of my projects.

    after the latest update to 1.8.3 i’ve noticed a bug (which happened after an update to an earlier version as well, where it got fixed after some time. so… hopefully no biggie ?? )

    my settings are:
    – center overlay on scroll
    – show titles (alt-tags)
    so when there’s no title the overlay image stays in the middle of the screen, as intended.
    as soon as there’s a title the image scrolls.

    as a work-around, adding this to my stylesheet seems to do the trick:

    #fancybox-title { position: fixed; bottom: 10px; }

    The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)

  • Hi, this is actually not a bug but intended behavior. The “problem” is that the script always places the image in the center also when there is a title. This means that when the image has to be scaled down to fit the window, and there is not much room left below the image for that title then the script disables the center-on-scroll behavior so that visitors can scroll down to read the title.

    The centering effect on scroll can be particularly annoying when there are very long titles (or rather: descriptions) that take more than one line. But if you set the title position tp “Float” or “Overlay” then all images (with or without title) should center on scroll.

    You are right, this is confusing. I’ll try to add some explanation in the settings…

    as a work-around, adding this to my stylesheet seems to do the trick:

    #fancybox-title { position: fixed; bottom: 10px; }

    This is actually a very nice solution. If you don’t mind, I’d like to add this as a new title position option in a future release ??

    Thread Starter getupworks

    (@getupworks)

    This means that when the image has to be scaled down to fit the window, and there is not much room left below the image for that title then the script disables the center-on-scroll behavior so that visitors can scroll down to read the title.

    makes sense. when i reduce the #fancybox-content height by a few pixels everything keeps centered. what confuses me is that it worked like this until the latest update.
    i guess i assumed the script calculates the height of the viewport and the height of the title, and then scales the image accordingly. which would still be a problem with long texts.

    This is actually a very nice solution. If you don’t mind, I’d like to add this as a new title position option in a future release ??

    sure, glad i could help.
    thanks for providing this plugin!

    • This reply was modified 6 years, 10 months ago by getupworks.

    I’ll do some testing and see if it can be made to work as before again. Or at least for titles that only take one line ??

    Thread Starter getupworks

    (@getupworks)

    nice, thanks!

    after some more testing this seems to work better, since it also gets the scroll animation:

    #fancybox-title { position: absolute; bottom: -10px; }

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Bug after update to 1.8.3’ is closed to new replies.