• Resolved wundermatics

    (@wundermatics)


    Hi,

    Thanks for a great plugin! We’re using in our functional/integration tests for our plugin WunderAutomation. We’ve recently added support for BuddyPress which made us trip over an issue in the BuddyPress log class in WP Mail Catcher.

    On line 23, the BuddyPress log class calls LogHelper::saveMail() with one parameter. But the trait method in question expects two parameters, so an error is thrown:

        public function recordMail($status, $bpMail)
        {
            $this->saveMail($this->getMailArgs($bpMail));
        }

    In our tests, we can override this behavior by unhooking the bp_send_email_success filter, so we’re good. But you probably want to fix this anyway.

    Keep up the good work.

Viewing 1 replies (of 1 total)
  • Plugin Author JWardee

    (@wardee)

    Hey @wundermatics, thanks for the report. I’ve open up an issue on the GitHub repo. I’m going to close this issue here, but feel free to comment on the issue in GitHub and I’ll respond there.

    This info is very helpful in helping me get a patch out so thank you for being so detailed! ??

Viewing 1 replies (of 1 total)
  • The topic ‘BuddyPress log helper throws error’ is closed to new replies.