Breaks menu ident

  • Resolved joshuaall

    (@joshuaall)


    6 years, 10 months ago

    The new version of the Enhanced Media Libary-Pugin introduces new Settings, indented after Media at Settings. Like in this picture: https://i.imgur.com/BD2Aue7.jpg

    However, saving changes in Admin Menu Editor breaks this indent, no matter if the Items where moved or not. I don’t know which way they achieved this indent. Can you either add compatibility to this Addon? Or preferably allow us achieving our own ident e.g. by adding empty lines before the menu title (which is not working right now)?

Viewing 4 replies - 1 through 4 (of 4 total)

  • Hi @joshuaall,

    Thanks, I was able to reproduce the issue. Will try to fix it for the next release.

    Best,
    -Nadia (EML’s author)

    Thread Starter joshuaall

    (@joshuaall)

    @webbistro
    thats great to hear. thanks alot for this fast reaction ??

    Plugin Author Janis Elsts

    (@whiteshadow)

    One way to work around the issue would be to switch the function that adds the indents from the custom_menu_order hook to the admin_menu hook and to give it a lower priority. This can be done by changing line #132 in core/options-page.php from this:

    add_filter( 'custom_menu_order', 'wpuxss_eml_submenu_order' );

    To something like this:

    add_action( 'admin_menu', 'wpuxss_eml_submenu_order', 15 );

    (That’s just a quick proof-of-concept.)

    The reason this works is that Admin Menu Editor reads menu properties immediately after the admin_menu action. It doesn’t “see” any menu customization that happens during later actions like custom_menu_order. Moving the callback to admin_menu ensures that the menu editor will know about the indents and and include them in the custom admin menu configuration.

    Hi Janis,

    Works perfectly, thank you very much for your help!

    For anyone interested: the change will be available in the next Enhanced Media Library update.

    Best,
    -Nadia

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Breaks menu ident’ is closed to new replies.