Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author ONTRAPORT

    (@ontraport)

    Hi Squibler,

    Can you e-mail us at [email protected]?

    Thanks!

    Couldn’t get this working when the home url differed to the site url. When non-members tried to login (like the site admins), they were redirected to the WordPress folder url and received a “page not found” error.

    This seems to be because site_url has been used in a number of the redirect and cookie statements.

    In the pilotpress.php file I modified certain instances of site_url to home_url.

    Changes as follows:
    Line 1350:
    $cookie_domain = str_replace($this->get_protocol(),"",home_url());

    Line 1395:
    wp_redirect(home_url());

    Line 1405:
    wp_redirect(home_url());

    Line 1436:
    Changed the site_url function to include the path in the function call, not append it to the returned valued:

    wp_redirect(site_url("/wp-login.php?checkemail=confirm"));

    Line 1460:
    wp_redirect(home_url());

    Line 1606:
    wp_redirect(home_url());

    Line 1999:
    $redirect = home_url($_SERVER['REQUEST_URI']);

    Still testing but the problem seems to have disappeared.

    Plugin Author ONTRAPORT

    (@ontraport)

    Hi CharlyLeetham,

    Thank you for reporting this issue. Our developers are working to address this problem and will release a new version of PilotPress shortly containing a fix.

    Thanks!

    cybernet0

    (@cybernet0)

    Same problem as CharlyLeetham … 6 months later, still not fixed.

    Here is a simple patch for the latest version (1.6.0f):

    https://pastie.org/8463510

    Note: redirecting to site_url makes NO sense, except for building links to “internal” WP functionality, such as to wp-login.php, wp-activate.php, wp-cron.php, wp-signup.php, etc.

    There’s ABSOLUTELY no reason to redirect to a bare site_url(). On most setups, home_url() and site_url() are the same, so mixing them up creates headaches for anyone without the same for both.

    No one wants to be redirected to example.com/wordpress (which usually results in WP errors) instead of example.com…

    That’s why the “use site_url()” setting makes no sense at all.

    P.S. Please use a PHP beautifier/formatter on the code – it makes collaboration almost impossible without frustration.

    P.S.2 Consider moving this plugin to GitHub – especially if you don’t have the time to maintain the plugin.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Breaking’ is closed to new replies.