\BQW_SP_Slide_Renderer::add_link_to_main_image() esc_url called on shortcode

  • Resolved Serge Liatko

    (@sergeliatko)


    3 years, 4 months ago

    Hi David,

    Serge here,
    Noticed a bug in the \BQW_SP_Slide_Renderer::add_link_to_main_image() it calls esc_url() on $main_image_link_href in line 273

    At the time of the call the $main_image_link_href is a shortcode [sp_link_url] and not the actual URL, so the output results in extra https:// prepended at the moment of rendering, breaking the links in slides (dynamic posts slider) and the lightboxes.

    Sending you details to your support email with screenshots. Posting here to make sure you have the issue tracked on WP.

    Thanks,

    PS. congratulations on publishing the slider on WP, we all have been waiting for this for a long time.

Viewing 1 replies (of 1 total)
  • Plugin Author bqworks

    (@bqworks)

    Hi Serge,

    I’ve just released an update to fix this bug.

    Thank you for your patience! ??

    Best,
    David

Viewing 1 replies (of 1 total)
  • The topic ‘\BQW_SP_Slide_Renderer::add_link_to_main_image() esc_url called on shortcode’ is closed to new replies.