Banner link invalidated if with hyphen

  • Resolved Ludovic S. Clain

    (@ludovicsclain)


    8 months, 3 weeks ago

    Hey there ???

    I have the impression of having encountered a bug in your plugin, here is how to possibly reproduce it on your side:

    1. Create a brand with a 2-word name (so that the slug has a hyphen for example), for example “my brand” (slug: my-brand)
    2. Enter in “Banner link” a link to the existing category which also contains a slug with a hyphen, for example https://monsite.fr/wc-prod-brand/my-brand/

    Result: the Banner link is not taken into account, it is replaced by the default link of your plugin (as if the “Banner link” field had never been filled in).

    Example with a one-word Banner link slug. In admin:

    Example with a one-word Banner link slug. In front:

    ???So, the banner link is the right.

    Example with a two-word Banner link slug. In admin ???

    Example with a two-word Banner link slug. In front ???

    ???The default link is set, as if Banner link had not been entered ????

    Hope it helps!

    Warm regards,
    Ludovic

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Support Janilyn T

    (@janilyn409)

    Hi Ludovic S. Clain,

    Maybe you have mistaken this a little bit.

    The image you added is the Logo for that brand, not the Banner: https://prnt.sc/0YOE0pRe4Trj. Please check it again. So when you points the mouse to it, it obviously links to the brand page. The Banner section in the brand settings is still empty in your image.

    On the other hand, the Brand link box is for users to enter a link so that when customers points on the Banner on the brand page, they will be redirected to a different destination. It’s for embedding a link to the banner, not for customizing the banner link: https://app.screencast.com/KtIUB7GKtmpPg

    Best regards.

    Thread Starter Ludovic S. Clain

    (@ludovicsclain)

    Hey ?? 

    Indeed, there was something that had escaped me, I made up an explanation which was a bad idea. And it turns out that I only use logos not banners, so when I dug deeper I realized that it was another plugin that linked to logos, “Gallery Custom Links” from Meow Apps. Thank you for your feedback, your explanations, your patience, and sorry for the inconvenience.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Banner link invalidated if with hyphen’ is closed to new replies.