Automatically award based on points

Just covering bases here. Are you sure all of the steps for the given achievement were met?

Yes, there are no steps for the Levels achievement types.

I have an achievement type called levels – the first badge is “level 1” and set to auto-award once user has reached 50 points. Level 2 when they reach 100 points, etc. So the users go about earning their other badges, and when they’ve earned enough badges & enough corresponding points, the levels badges auto-award.

They weren’t working last year. The update this summer (as above) fixed the issue. Now, all the sudden, the issue is back.

Honestly not sure why it’s failing again, especially since there haven’t been any updates yet since. Only thing I have is possibly some deep rooted bug or something askew with the logic that I’m not accounting for in my head, based on data available in your site.

The BadgeOS Community Add-On plugin was updated 6 days ago. The changelog there doesn’t seem to indicate anything that should be conflicting with this, but the timing does seem to correspond. Will make some time for further testing and see what I can isolate as a possible cause. You’re right though, logically, it’s a really weird one.

Yeah, those changes won’t relate to this at all.

My webhost was able to isolate the issue. Here’s the fix:

I’ve confirmed that when disabling HHVM on your install BadgeOS performs as expected, when enabling HHVM the badge level triggers were not fired. I looked into your HHVM error logs and found multiple warnings with the below line:

\nWarning: time() expects exactly 0 parameters, 1 given in […]/wp-content/plugins/badgeos/includes/rules-engine.php on line 111

Looking at line 111 of plugins/badgeos/includes/rules-engine.php:

// If the user just earned the badge, though, don’t let them earn it again
// This prevents an infinite loop if the badge has no maximum earnings limit
if ( $last_activity >= time(‘-2 seconds’) )
$return = false;

Looking at HHVM implementation of PHP’s time() function: https://docs.hhvm.com/manual/en/function.time.php

So infact the code block is “wrong”, they are calling time() incorrectly and thus the badges are not being triggered correctly. The correct use of the time() function should be this:

// If the user just earned the badge, though, don’t let them earn it again
// This prevents an infinite loop if the badge has no maximum earnings limit
//if ( $last_activity >= time(‘-2 seconds’) )
$timeminus2 = time() – 2;
if ( $last_activity >= $timeminus2 )
$return = false;
}

I’ve corrected the code in the above file and re-ran the test. Success! the mission badge is now successfully triggering next level workflows and no more warnings or errors are showing up in the log for badgeos.

Interesting, and good catch. I’ve double checked and this has been a line in the code since before I’ve been involved at all as well. It’s also one that’s looking to be valid in all current versions of PHP, not just HHVM(kudos for using it btw). I will get this fixed and possibly an update to the plugin as a whole. Curious if it’ll solve other random issues coming up, but no guarantee.