Apple Pay – invalid URI with custom folder structure

  • Resolved werbebo

    (@werbebo)


    2 years, 11 months ago

    There is a problem with Apple Pay verification when using a different folder structure. (Bedrock for example – https://roots.io/bedrock/)

    array(
  'test_mode' => false,
  'domain_name' => 'www.example.com/wp',
)

    Error Message: You passed an invalid URI for your domain name. It must not contain a port, path, query, or fragment, and should be just a bare top-level domain, such as https://www.example.com

    If you hardcode the domain_name parameter in class-wc-payments-api-client.php (Line 1349) it works.

    • This topic was modified 2 years, 11 months ago by werbebo.
    • This topic was modified 2 years, 11 months ago by werbebo.
Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Support nicw.a11n

    (@nicw)

    Hi @werbebo

    Thank you very much for the input. It does appear that the problem lies with this line.

    We will open an issue on Github.

    While changing the core WooCommerce Payments code will work in this case, it will be important to remember each time the plugin is updated the workaround wil need to be redone.

    Wow… three months without this very simple bug fixed!

    All afternoon on the phone with my host checking the server’s SSL and TLS settings… then on chat with WooCommerce going through various troubleshooting steps. Finally, he asks me to trigger the error log and we see an error message that the domain name erroneously contains a subdirectory.

    Even after finding the issue via chat, WooCommerce tech support is completely unaware of this bug. Not only that, their suggested solution was to toggle Express Payments option on/off to force a manual refresh of the domain. Of course this would never work because the code is written to fetch the subdirectory.

    I finally had to modify this line of the plugin identified above. I changed get_site_url() into get_bloginfo('url'), which correctly returns only the site’s domain name without a subdirectory.

    This worked and Apply Pay was activated, but it’s not an acceptable long-term solution as it will break as soon as the next plugin update is applied.

    How this was never fixed months ago is absolutely absurd. Lots of people give WordPress its own directory; so many that there’s even this support article at WordPress about it.

    I wonder how many of the 455 million WordPress installations are in a subdirectory, AND also use this plugin? Surely it must translate into many many tens of thousands missed opportunities to activate Apple Pay.

    Plugin Support Kaushik S. a11n

    (@kaushiksomaiya)

    Hi there!

    Thanks for your comment.

    I understand what you are saying. Please note that the bug report for this issue has already been filed here: https://github.com/Automattic/woocommerce-payments/issues/3565 and our developers are working on it.

    I cannot comment on the time it would take to get the bug fixed, but I recommend subscribing to the Github bug report for tracking the status of the bug.

    I hope that helps!

    Yes, Apple Pay is broken on my site for the exact same reasons.

    I know it used to work in the past, so they have introduced this bug in an update (or change in policy at Apple Pay)…

    Hello @bluewave99 ,

    I am sorry to hear that you are still having this problem.

    It looks like there weren’t much activity on the bug report so I’ve pinged our developers to get some update.

    Please subscribe to that bug report to get updates on it.

    Thank you.

    Don’t know if handled correctly but I just opened a Pull request to see if that can speed up a bit the fixing.
    Last plugin update seems still affected.

    Plugin Support B C. a11n

    (@battouly)

    Hey @photoironic,

    I’m not sure if that will speed up the fix, let’s hope it will. ??

    I’d recommend adding a comment on the issue for developers too.

    Absolutely ridiculous.

    I think something like six updates have been pushed out since this bug was reported and none contain the fix. Imagine the millions of missed opportunities to use ApplePay caused by this – Apple should be thrilled. Ding dong!

    Plugin Support B C. a11n

    (@battouly)

    Hey @sparky672,

    We have pinged the developers internal for updates on this. Will let you all know via this open ticket on where the bug is in their backlogs.

    For now, a priority has not yet been assigned to the issue.

    Thanks!

    Hi @battouly!
    I wrote the pull request filling up all the suggested fields and cited the Issue already opened on Github five months ago: https://github.com/Automattic/woocommerce-payments/issues/3565

    I don’t know what else to do except waiting for approval, it’s a known bug never addressed in more than 5 months so I hope someone find a couple of minutes to review it.

    Plugin Support nicw.a11n

    (@nicw)

    Hi @photoironic

    Thank you so much for the pull request – we’ve brought it to the attention of our developers and you should see some movement on it soon. Thank you for helping out in the open source community!

    Plugin Support ricardometring

    (@ricardoa8c)

    This should be fixed in WooCommerce Payments 4.3.0 in our next release on June 15th.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘Apple Pay – invalid URI with custom folder structure’ is closed to new replies.