Anchor tag Aria Label Issue

  • Resolved Efflux Perceive

    (@divyeshsapariya35)


    1 year, 4 months ago

    Hello There,

    I have used your plugin, and it’s a very helpful and great plugin. However, I have reviewed your plugin’s code and I’d like to inform you that there is one important issue that needs to be addressed for the benefit of your plugin’s users.
    You can see the screenshot below of the code; you need to set the ‘aria-label’ dynamically to match the anchor text. This adjustment will help resolve the Google LCP issue.

    Method Name: get_button_link()
    Path: src/renderers/moderns/class-modernrnderer.php

    Please check and let me know your thoughts,
    Thanks!

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Jerry Rietveld

    (@jgrietveld)

    Hi there, thanks so much for taking the time to dig into the code and write this message to us! We really appreciate it. The issue you’re describing is on our backlog but we hadn’t gotten to it just yet. The aria-label should match the button label when there is one. Only when it’s not present, it can fall back to the default. We’ll push this item up on the priority list and try to add it over the coming days!

    Thanks again!
    Jerry

    Plugin Author Jerry Rietveld

    (@jgrietveld)

    Hi there, thanks again for your message. We’ve just released version 1.4.2 which contains the fix for the aria-label. So the aria-label will take the content of the label you have added to your button.

    Cheers,
    Jerry

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Anchor tag Aria Label Issue’ is closed to new replies.