amp-img

  • Resolved liagua

    (@liagua)


    7 years, 2 months ago

    Dear AMP,

    Another question. The images on my AMP-homepage are not visible. Due to the fact that the *.jpg and alt are merged and the image description is being handled as, i don’t know. The image description is in this case is 3 separate words replaced with ‘part_img_desc’

    As you can see the code generates(attributes) =”” after each word and places alt straight behind *.jpg without closing the image.jpg with a ”

    amp-img src=”https://www.website.com/wp-content/uploads/image.jpgalt” ==””
    “part_img_desc=”” part_img_desc=”” part_img_desc”=”” width=”100″ height=”75″ class=”i-amphtml-element i-amphtml-layout-fixed i-amphtml-layout-size-defined i-amphtml-layout amp-notsupported” style=”width: 100px; height: 75px;”></amp-img>

    Is there a way to fix this within the code?

    Regards,
    Ronald

    • This topic was modified 7 years, 2 months ago by liagua.
Viewing 11 replies - 1 through 11 (of 11 total)
  • Thread Starter liagua

    (@liagua)

    Resolved the attributes by disabling another plugin. But it didn’t resolve the issue from merging the jpgalt

    I’ve edited the “features.php”at line 3361
    from:
    echo ‘alt = “‘. esc_attr($thumb_alt). ‘”‘;

    into:
    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    Could you please confirm that this is an little bug your side, else I have to dig deeper

    Regards,
    Ronald

    Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    Hi Ronald @liagua

    That’s extremely strange, I am not aware of such issue but it’s possible that it’s a bug in the plugin.

    Can you share the URL where you are getting the error? I will make sure that it is fixed in the next update.

    I am still not 100% clear about this issue, if you share the URL then it will help me understand it but it seems like a valid issue and I will go ahead and create a ticket for it here: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/1154

    Please share the screenshots or URL.

    Thanks again,

    Regards,
    Ahmed

    Plugin Contributor ampforwp

    (@ampforwp)

    Hi Ronald @liagua

    Could you please use this code and test it? I’m not sure it will work or not on your end but on my end, it’s working.

    Here is the code:

    echo ‘alt=”‘ . esc_attr($thumb_alt) . ‘”‘;

    If it’s not working, please just drop the email to [email protected]. Our team will help you.

    Thread Starter liagua

    (@liagua)

    Hi guys,

    The code you supplied isn’t working for me.
    It still binds togheter the .jpg and Alt=
    like so:
    <amp-img src=https://www.website.com/wp-content/uploads/imagename.jpgalt=”name of the image”

    I’m resolved the issue using

    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    Regards,
    Ronald

    Thread Starter liagua

    (@liagua)

    Hi guys,

    In version 0.9.66.0 I also resolved this issue using:

    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    instead of

    echo ‘alt=”‘ . esc_attr($thumb_alt) . ‘”‘;

    Regards,
    Ronald

    Thread Starter liagua

    (@liagua)

    Hi guys,

    In version 0.9.66.1 I also resolved this issue using:

    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    instead of

    echo ‘alt=”‘ . esc_attr($thumb_alt) . ‘”‘;

    Regards,
    Ronald

    Thread Starter liagua

    (@liagua)

    Hi guys,

    In version 0.9.68 I also resolved this issue using:

    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    instead of

    echo ‘alt=”‘ . esc_attr($thumb_alt) . ‘”‘;

    Regards,
    Ronald

    Thread Starter liagua

    (@liagua)

    Hi guys,

    In version 0.9.69 I also resolved this issue using:

    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    instead of

    echo ‘alt=”‘ . esc_attr($thumb_alt) . ‘”‘;

    Regards,
    Ronald

    Thread Starter liagua

    (@liagua)

    Hi guys,

    In version 0.9.69.1 I also resolved this issue using:

    echo ‘ alt=”‘. esc_attr($thumb_alt). ‘”‘;

    instead of

    echo ‘alt=”‘ . esc_attr($thumb_alt) . ‘”‘;

    Regards,
    Ronald

    Thread Starter liagua

    (@liagua)

    Hi guys,

    In version 0.9.71 it appears to be resolved:

    Thank you very much!

    Regards,
    Ronald

    Plugin Author Mohammed Kaludi

    (@mohammed_kaludi)

    Im glad to hear that. Please share a review. That will mean alot to us.

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘amp-img’ is closed to new replies.