After last update, the plug in sends zero length files

Does changing it to $handle = fopen( $file, 'rb' ) make it work fine for you?

No, I use Linux so “b” has only formal meaning. Other operating systems need it though, so you should add it to your sources.

In order to make my download non zero I must comment out the

ob_flush();
flush();

functions. Of course that means PHP will load the whole file in memory and thus it’s not a good workaround as PHP easily goes out of memory with these day’s big files.

There are alternate solutions to the edd_readfile_chunked() both on StackOverflow.com and PHP.net, some even support download resuming.

Hmm. Removing ob_flush() and flush() is probably not a good idea for most users (great that it works for you though).

I’ll dig around some more to see what I can find.

Yes in my case I might just replace the function with this resumable downloads one.

The current implementation won’t send headers or check for compression.

For sure, if I had just paid for a download that fails and EDD was configured to only let download once, that solution would serve me much better.

My only thing is, I can’t tell you “hey this works great!” because it’ll be just the solution to my personal issue, while it has to be tested on a large range of servers and configurations.

Having the same issue. Under the exact same configuration.

The problem seems to have been solved using the solution proposed by dfumagalli.

Waiting for an updated version of EDD that fixes the problem properly.

Thanks

Having the same issue. Under the exact same configuration.

The problem seems to have been solved using the solution proposed by dfumagalli.

Waiting for an updated version of EDD that fixes the problem properly.

Thanks

Yes, I think that edd code function is quite old and does not make use of modern browser demands like i.e. the content attachment type and similar.

I’d love to get a patched EDD version myself as I don’t like to hack in my WP mods, releases are too frequent to keep re-applying those manual patches every next release.

Sorry double posted.

I’m having another user test this patch as well (hard to test when you can’t replicate the problem). If she confirms that it works for here as well, I will commit it to core.

She just confirmed that removing those lines fixed it for her as well. I’m committing the changes for EDD v1.8.

There’d be the ultimate test to perform before committing:

Setup a 100M download and see it deliver.

Those lines were there to prevent PHP loading up all the available memory, I don’t know if current Apache still needs them or not, setting up that test would be quick and resolutive.

Yep I’m going to test that.

seems i have the same problem with 0kb files. My customers reported yesterday what they get 0 Kb when trying to download my video files(they are big, more then 158 Mb), but the small ones around 600Kb downloading OK.
Btw, i still on EDD Version 1.6.4.
Do i need to update now to 1.7.2 or i can wait and update to v1.8 when its ready?
Pls, need help.

1.8 will be out near the end of this month.

Please manually apply the patch above.

Initial tests seem to confirm the latest patch fixed this issue.

Great!