• Resolved shane_idc

    (@shane_idc)


    hi I have a clients website sprinkle.com.au around 1400 pages with 3 genericon’d icons on each. A while ago I updated from 3.4.1 to 4.0.1 – the plugin broke the page!! the icons became massive!!! like 6-10 times bigger https://itdoescompute.com.au/wp-rollback-plugin-so-very-necessary/ Now Im about to update wordpress on her site and add SSL but I cant update genericon’d because of the same issue still existing, just tested it on my itdoescompute website, it still breaks. Pleeeeease help!

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    That’s a CSS issue then. You must have a conflicting css rule that’s overriding and making the images larger.

    Have you a link to a page having the issue?

    Thread Starter shane_idc

    (@shane_idc)

    Hey Mika, thanks for response. Um not css I think its this – which is on every collection item page e.g.: [genericon icon=reply-single size=2x] you can view source on https://sprinkle.com.au/collections/2017-springsummer-la-mediterranee/st-tropez-wrap-dress_01/ – but no way im updating the plugin – the error will occur on 1400 pages or so!

    See my previous post link – there are screen shots of the error. Maybe you changed the shortcode between 3.4.1 and later editions? What do I do? Can I css the error out of existence?

    Plugin Author Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    Well… You won’t like it, but debugging means you upgrade and then view the CSS to see where it’s setting the size.

    The plugin works fine on a vanilla WP, with the default theme, so ‘something’ is telling it to be bigger. Now that said… The plugin DOES change from fonts to svg. And it’s possible that’s what went bibbeldy.

    By default, Genericons Neue and Social Logos are both active and use SVG sprites, not fonts. If you want to go back to displaying the icons as a font, you can do so via settings. That should keep you running.

    Thread Starter shane_idc

    (@shane_idc)

    okay ill update the plugin on my ‘itdoescompute’ website (i use genericon’d there too but just in the menu) and leave it broken – what do i look for? Do i open the plugin editor and check genericon’d css? will i be able to find the style in chrome ‘inspect element’?

    ah ok just re-read – ill try changing SVG to fonts in settings after ive updated.

    thanks, let you know soon…

    Thread Starter shane_idc

    (@shane_idc)

    ok so that will work update to 4.0.1 – check all three [o] Genericons Neue [o] Social Logos [o] Legacy Fonts settings boxes – except for one thing. The shopping cart and question mark icons show – but youve changed the name of one of your genericons from “reply-single” to “reply” (the up-backwards left pointing arrow) which of course I use on all of the range item pages (over 1000). So now [genericon icon=reply-single size=2x] has to instead read [genericon icon=reply size=2x]

    What do I do? It just shows a black box instead of the arrow. Do you have a work around? Or I have to try “better search replace” plugin?

    Thanks,,,

    Plugin Author Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    I didn’t change the name of the generic, the library did (I didn’t even notice that one…). You’ll have to search-replace OR… Try putting this CSS in your theme:

    .genericon-reply:before { content: "\f467"; }

    Thread Starter shane_idc

    (@shane_idc)

    Managed to figure things out:

    Your .genericon-reply:before { content: "\f467"; } suggestion didnt work out when testing on itdoescompute (older wordpress version tho) but changing the icon name did.

    With Sprinkles website the 4.0.1 update did not change the icon size this time (wtf????) so the problem was the black box place holder instead of the icon which I used Better Search Replace plugin to change [genericon icon=reply-single size=2x] to [genericon icon=reply size=2x] which worked fine, phew.

    The other thing – with the SVG update there was now an icon margin of 4px which messed the site a bit – pushing the icons on to two lines instead of displaying on one. I fixed this with svg.genericond-genericons-neue /*--4.0.1 addition--*/ {margin:0px;}

    Thanks for all your help and clues Mika, I will do a new Genericon’d post and explain the work-around… =D

    • This reply was modified 7 years, 7 months ago by shane_idc.
    Plugin Author Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    That it only happened on one site suggests that there’s a conflict (probably with your theme) that’s overriding the plugin. And for what it’s worth, that’s intended. The plugin should ALWAYS let the theme win, in my opinion.

    Your fix for the 4px margin is the right one ??

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘after 3.4.1 icon size is massive so had to rollback’ is closed to new replies.