Admin CSS

  • Resolved Wombat Plugins

    (@maartenbelmans)


    3 months ago

    Hi team,

    I’d like to discuss 2 issues:

    1) In the admin, your CSS files are included on every admin page, including CPT pages. Shouldn’t it only be included on the pages you add options to?

    2) One of your CSS files is including this CSS: https://i.snipboard.io/Zo7Iaw.jpg Since it is not prefixed and loaded on every page, this is messing with a plugin I use. That plugin also adds a page to the admin and your CSS is loading on it and hiding that plugin’s divs since “data-steps” is quite “universal” ??

    Thanks!

Viewing 4 replies - 1 through 4 (of 4 total)
  • Eduard

    (@cteduard)

    Hello @maartenbelmans

    Sure, we can take a look at this. Could you please let me know which plugin is the CSS conflicting with?

    Thanks!

    Thread Starter Wombat Plugins

    (@maartenbelmans)

    Hi @cteduard

    This one, but it will be any plugin that adds HTML with a data-steps attribute. Any plugin that’s adding multi-step wizards is potentially affected by this as “data-steps” is a fairly common attribute name.

    Ideally, you only run your CSS on the admin pages it is needed and you prefix general rules so it is only applies to your HTML elements. Example: .blocksy-container [data-steps] div {...}

    Thanks!

    Eduard

    (@cteduard)

    Hello @maartenbelmans

    Thanks for letting me know. However, I would also argue that the plugin itself might need to prefix their declarations. This goes both ways, I’m afraid.

    Nevertheless, the developers have managed to prefix these declarations and the next public update will include them. If you wish to get a pre-release build of the update, you will need to drop us a line through our website: https://creativethemes.com/blocksy/support/, as giving .zip files through these forums isn’t really permitted.

    On the note of loading assets on the admin pages, I have started an internal discussion to see how we can tackle these. I will be sure to share with you our findings once we have something.

    Thanks!

    Thread Starter Wombat Plugins

    (@maartenbelmans)

    Hi @cteduard

    Thanks for that! Looking forward to the update.

    On your first comment: WooCommerce Discounts is correctly prefixing its CSS by using .wdp- for elements that may otherwise conflict. It is your plugin that’s using [data-steps] in CSS directly, so this is a one way issue here I’m afraid and all yours to fix. ??

Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.