Additional output in HTML
-
Looking to purchase EventOn, and am testing the Lite version now.
I have the settings: “Load eventON scripts and styles only on eventON pages” ENABLED “Load all eventON scripts/styles to page headers, where eventON is used” DISABLED. Testing with a page that has no EventOn content on it, the front end page still has some EventOn data in it:
In the header:<!-- EventON Version --> <meta name="generator" content="EventON 2.2.21" />
And just after the footer:<div class="evo_elms"><em class="evo_tooltip_box" /></div><div id="evo_global_data" data-d="{"calendars":[]}" /><div id="evo_lightboxes" class="evo_lightboxes" style="display:none"> <div class="evo_lightbox eventcard eventon_events_list" id=""> <div class="evo_content_in"> <div class="evo_content_inin"> <div class="evo_lightbox_content"> <div class="evo_lb_closer"> <a class="evolbclose ">X</a> </div> <div class="evo_lightbox_body eventon_list_event evo_pop_body evcal_eventcard"> </div> </div> </div> </div> </div> </div>
I would argue that neither of these should be included if no EventOn data is included in the page. I would also argue that there should be an option to disable the version number of the plugin from being output, may make it easier for a bot to detect a vulnerable plugin in the future.
Looking at the code, it appears as the functions that output the block of html (class-lightboxes.php and class-frontend.php) don’t do the evo_load_scripts_only_onevo check before adding to the footers. Shouldn’t it? I dont have any EventOn content on this page, thus I can’t have any lightboxes that need the elements.
Thanks!
- You must be logged in to reply to this topic.