Adding some hooks

  • Hello Smash Balloon –

    Nice plugin. Pretty much works as expected ??

    Question / suggestion: Is there any chance of adding some filters so someone would be able to customize the output? For example, your default grid display is certainly solid, but we have some other things in mind. The ability to hook in via a filter, receive the necessary data and output our own output would be helpful.

    Worst case, it looks like you might be storing the images in a transient, correct? In that case, I think there’s a workaround. Can you confirm there is a transient for the images, as well as what the name of that transient is. Please? I’m sure I can figure it out but this need kinda popped up out of nowhere and I’m trying to save time, if possible.

    tia –
    mfs

    p.s. As a general best practice it’s probably best you escape your frontend values. I’m pretty sure I saw things being aggregated on to a string that is eventually displayed as the grid. Yeah, you can assume you can trust the source (IG) but just in case, it’s still good to escape. In theory, someone could put something nefarious in the DB (e.g., transient) and you’re not making sure it’s clean.

    I hope that helps. For now I’m mainly interested in the hooks / transient issues.

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Craig at Smash Balloon

    (@craig-at-smash-balloon)

    Hey ChiefAlchemist,

    The good news is that all of these issues (including the escaping) will be addressed in our 2.0 update coming out in a few weeks.

    We have plans to make the layout easier to customize (though we are not settled on exactly how yet). It will come with a guide either way.

    Let me know if you have more questions in the meantime.

    – Craig

    Thread Starter ChiefAlchemist

    (@chiefalchemist)

    Cool. When will that happen?

    FWIW, I usually just add a filter that sends a bool + any other args. If a non-bool comes back that means the filter was used and the string is what I would have done in my code (for the view / presentation). Does that make sense?

    So yeah. When? Maybe I should just fork the current version?

    Plugin Author Craig at Smash Balloon

    (@craig-at-smash-balloon)

    Thanks ChiefAlchemist!

    Currently we are considering allowing people to create custom files in their themes that override the existing templates. Your idea also makes sense. We might even be able to do both actually.

    If you’d like, you can test our github branch and create your own template using the php files. Just save a copy of your HTML before updating for now as there isn’t any support for customizations as of yet.

    Thread Starter ChiefAlchemist

    (@chiefalchemist)

    Thx Craig –

    I’ll have to look at that tomorrow / over the weekend. Thx for sharing.

    Me? I would add a filter and as long as you pass all the necessary args that’s all anyone should need. Oh! Typically, I pass, aside from the bool flag, a single array of args. Using an array makes it easy to add args in the future without having to worry about any backward compatibility issues. That is the filter has 2 args forever ??

    Finally, I threw this together earlier today. We needed a widget, not a shortcode. Let me know what you think.

    https://gitlab.com/WPezPlugins/wpez-instagram-feed-widget

    Plugin Author Craig at Smash Balloon

    (@craig-at-smash-balloon)

    Very nice! That’s a clever way of changing the header and footer in our plugin I see. This will definitely be easier in the future ??

    We’ll be discussing our options for hooks, customizations, etc.. this week. I’ll let you know what we go with as far as how it will work.

    Thanks again,

    Craig

    Thread Starter ChiefAlchemist

    (@chiefalchemist)

    Yeah, it was the best I could do given my options ??

    Plugin Author Craig at Smash Balloon

    (@craig-at-smash-balloon)

    Hey again,

    We decided to use custom templates in a theme’s files for now. We will be adding some additional hooks over time too though. So not exactly like your suggestion but we do appreciate it!

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Adding some hooks’ is closed to new replies.