add filter to modify html classes

  • Resolved nicmare

    (@nicmare)


    7 months, 1 week ago

    Hi there,

    i want to streamline the visual output of the embed privacy content. For instance i need to add a certain class to the checkbox input (currently it is “embed-privacy-input”). I took a look into your code and noticed all the classes are hardcoded. Can you please apply_filter here? Thank you!

    best Nic

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Matthias Kittsteiner

    (@kittmedia)

    Hi @nicmare,

    what prevents you from using the available class? You can also style the content with this class as you do with your own class.

    Best regards,
    Matthias

    Thread Starter nicmare

    (@nicmare)

    because the theme has already a complex css rule for certain plugins and therefore i would like to use one of these selectors like “ct-checkbox” for your plugin:

    View post on imgur.com
    Plugin Author Matthias Kittsteiner

    (@kittmedia)

    Okay, I understand your request, why you want this. However, this is not how CSS should work. Different elements should have different classes. If you add another class, it could have unintended side-effects, especially when CSS targeting theses classes suddenly changes by their original package.

    Additionally, having multiple selectors with the same applied CSS is exactly how CSS should work. It doesn’t make the selector more complex, just larger.

    Thus, I have no intention to implement such a filter. If you want, you can use the filter embed_privacy_markup to search for the original class of the input field and extend it (you should not entirely replace it as this may break functionality of Embed Privacy, which may rely on the availability of this class).

    Thread Starter nicmare

    (@nicmare)

    thank you – i really appreciate your opinion and the time you spend into this ticket. but i do not agree at all. there are many plugins out there allowing to change / add css classes. but glad there is an outer wrapper filter to change the markup to my needs. that is absolutely fine for me. thank you!

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘add filter to modify html classes’ is closed to new replies.