A few crucial bugs, and some recommendations

My apologies, some small corrections to the above issues after looking into the code some more:

– It is possible to disable the row hover in the CSS, although as far as I can tell it still isn’t possible to make it so that it applies to all rows instead of hovering. It would be great to be able to select that option or else opt to disable the hover entirely.

– The prayer name background issue seems to be partially a CSS specificity conflict on my side: the setting still doesn’t work, but it defaults to a white background, not #eeeeee

ASA brother Hashim,

SubhanAllah!
May Allah swt accept your intention and dua for the plugin.

I will address each issue that you have pointed out in my next update.
And some of them I will explain to you soon insshaaAllah.

You can see the current issues and development here, https://trello.com/b/6Re5Dga7/daily-prayer-time

Mustafiz.

I have since discovered another more important problem, and I’m pretty positive that this one is truly enabled dynamically and therefore cannot be disabled in the CSS.

Removing the rules for highlights from the styles.css file:

table.dptTimetable tr.highlight{
    background-color: #F5FF92 !important;
    font-weight:bold
}

table.dptTimetable th.highlight,
table.dptTimetable td.highlight{
    background-color: #F5FF92;
    font-weight:bold
} 

…makes absolutely no difference, as Firefox developer tools indicates the rules are set inline (i.e. dynamically?).

This is again highly critical as there is no way of changing this behaviour without knowledge of PHP, which many people working on masjid websites – including myself – simply don’t have. A fix for this ASAP would be appreciated.

• This reply was modified 5 years, 4 months ago by HashimA.

ASA

1. Its not hover on alternate but its background on alternate and hover went underneath the background. I don’t think its really important, so I took the alternate background off.
2. Fixed the prayer name background
3. correct, removed
4. Announcement/day is only for widget
5. will think about it
6. this it display either the prayer time only or jamat time only
7. done but the blink is important as it also controls the blink section on digital screen
8. Highlight may also used for other purpose in future, but I updated it as you suggested
9. this is needed to show the initial Highlight for next prayer, but I removed the !important

You can see them in the next release iA.

I was hoping if you can write a review for the plugin inshaaAllah.

Mustafiz.

Thank you for addressing all of the issues and fixes. Regarding #9, I was mistaken. These are the rules that are set dynamically:

table.customStyles tr.highlight, th.highlight, td.highlight {
    font-weight: bold;
    background: #81d742 !important;
}

…and removing !important makes no difference. Because they are set in the PHP they are inline, which makes the specificity higher than any other CSS, which in turn makes it impossible to change the highlight to another colour than green.

I also found another bug today, which I managed to find a fix for myself. When using a shortcode inside a theme template file like this:

<?php echo do_shortcode("[dailytable_horizontal use_div_layout=true hide_time_remaining=true]"); ?>

…I get the following error:

Warning: Illegal string offset ‘orientation’ in B:\Users\Hashim\Desktop\Mosque Website\XAMPP\htdocs\wordpress\wp-content\plugins\daily-prayer-time-for-mosques\Models\DailyShortCode.php on line 258

Adding $attr = array(); to the beginning of the scIqamahUpdate function (line 255), as found here, fixes this.

I definitely will write a review for the plugin soon, but I want to do so once crucial bugs like these have been fixed so that I can be confident it’s worth the full 5 stars I intend to give it.

Regarding the updated version of the theme, I have a question, as I’m not very experienced with how WordPress works. If I update the plugin to the latest version with the new fixes and improvements, will all the changes I’ve made to my styles.css file be overwritten?

Thanks again for all your help and co-operation on this.

Hashim

• This reply was modified 5 years, 3 months ago by HashimA.
• This reply was modified 5 years, 3 months ago by HashimA.
• This reply was modified 5 years, 3 months ago by HashimA.
• This reply was modified 5 years, 3 months ago by HashimA.

I’ve also noticed that the above issue with background-color being set in the PHP is also true for [dailytable_horizontal], and [dailytable_horizontal use_div_layout=true] doesn’t have the Begins/Iqamah column for some reason, so at the moment if I want both a Begins/Iqamah column and want to change the background colour (both basic and necessary, I think), I can’t, until the code that sets the colour in the PHP is dealt with.

SubhanAllah, I really need you to QA this plugin, you are really good at finding bugs, mashaaAllah.

I will address the new things iA soon.

1. !important is taken off from highlight in the last update already
2. will be fixed on the next release
3. yes, it will be overwritten, but in pipeline there is a css editor, where you will be able to write your overwritten css
4. for [dailytable_horizontal use_div_layout=true], it was a special request from a brother to add his css, I should remove it for general use

Releasing 2019.8.1

Haha, I just report things as I come across them during working on my website, and as it happens, I happen to work on the website a lot.

Once again, thanks for your effort on this project and your prompt response to bugs. Regarding #4, have you already removed div_layout? If so, I’ll have to avoid updating my plugin to the latest version, as my current implementation of the plugin on my website relies on it heavily and it would be a shame to lose it. If not, I highly recommend you don’t, as the divs make it much easier to style the plugin and make it match the website being implemented on.