A few bugs: Banner Options, accessibility, and block styles

  • Hi, thanks for creating this nice theme. I’m considering using it and ran into a few small issues while testing it.

    1. I’m interested in using the banner feature but not with the tagline, button, or both. However, it seems there’s no way to use the banner without having a button and tagline. When I delete the contents of the options for those elements, the default values get used (even though the empty values do get saved). I can ditch these things in a child theme easily, but that would be nice to avoid ??

    2. When tabbing through the menu, focusing on submenu items does not keep the submenu open and the first submenu item is the only one that’s accessible at all via keyboard navigation.

    3. Glancing at the social icon output, there is no accessible text label for each icon (using title attributes isn’t accessible). Also, some screen readers will read out the contents of icon fonts, so the icon itself should be aria-hidden. Better pattern would be (psuedo code)

    <a href="#"><i class="icon" aria-hidden="true"></i><span class="screen-reader-text">Social Network</span></a>

    4. The default blue color for the banner overlay (which I don’t see a way to change) is so bright that it literally can’t be accessible with white text regardless of the banner image. Therefore, while there’s a lot of great accessible code I’m seeing in the theme, that is one area that definitively isn’t.

    <h2>Block Editor Stuff</h2>

    I ran the site through the Block Unit Test plugin and found a few other things.

    5. The :visited link style seems to result in black-on-black text/background for the Button block in the new editor.

    6. Left- and right-aligned images don’t seem to have padding along the vertical edge that directly abuts the text. Similarly, the pullquotes don’t seem to have any interior padding.

    ————–

    Thanks again for providing the nice theme, and I hope this feedback can make it better.

    • This topic was modified 5 years, 7 months ago by mrwweb.
    • This topic was modified 5 years, 7 months ago by mrwweb.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Theme Author Ben Sibley

    (@bensibley)

    Wow thanks for such an in-depth review of Challenger! I’ve created a few Github issues to tackle these updates.

    While most of our themes are accessible, we haven’t tagged Challenger with the accessibility-ready label so it is not being held to those same standards. That said, I can and will make the updates you’ve outlined here as I would love to make it more accessible.

    The header color is the one aspect that isn’t going to pass accessibility requirements. However, there is a background color option available in the Customizer.

    I will address the padding issues for the blocks as well in the next update.

    Thread Starter mrwweb

    (@mrwweb)

    Glad to hear you’ll be addressing these!

    I totally overlooked the lack of accessibility-ready tag. My bad. I knew some of your other themes were so just assumed.

    Theme Author Ben Sibley

    (@bensibley)

    No worries. Sorry if that made things confusing!

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘A few bugs: Banner Options, accessibility, and block styles’ is closed to new replies.