2 suggestions to your awesome plugin!
-
I have 2 minor suggestions I make locally to your awesome plugin, that fixes the only 2 issues we always have.
1) Line breaks not respected.
– In your get_content() method (line 534) of lj-maintenance-mode.php you are using wpautop, but not nl2br. Because you are not using the WordPress get_content, you are losing the line breaks. To fix this simply put nl2br after the wpautop line e.g.
$content = apply_filters(‘wpautop’, $content);
$content = nl2br($content);2) No html wrapper
– Styling the css is limited because you don’t wrap the content in a div wrapper. If you were to wrap all the content in a div wrap (or even 2 would be better), then the styling possibilities would be far greater. e.g. we usually want our maintenance page to be a logo with contact details, center aligned vertical and horizontal. Without a div wrapper this is not possible.
– An easy solution is this (line 560):
return ‘<div class=”maintenance-wrapper”>’ . $analytify . $code . $stylesheet . $widget_before . $content . $widget_after . ‘</div>’;Thanks for such an aweosme plugin, I appreciate the simplicity!!
- The topic ‘2 suggestions to your awesome plugin!’ is closed to new replies.