2 Bugs

  • Resolved anantgarg

    (@anantgarg)


    6 years, 10 months ago

    Hi,

    There are two bugs in your code. Can you please help with the first one urgently. If you can give some idea, I can fix it myself:

    1. When “Custom Permalinks” plugin is activated and a custom permalink is used, in the revisioned page, the Preview button does not work. It redirects to the custom permalink instead of the correct id.

    2. function user_can_revisionize only considers the permission edit_posts. But for pages, it should consider the permission edit_pages.

    Thanks

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter anantgarg

    (@anantgarg)

    I’ve fixed the first issue. Let me know if you have a GitHub repo and I can do a pull request.

    Plugin Author jamiechong

    (@jamiechong)

    Github repo is here: https://github.com/jamiechong/revisionize

    1. Can you tell me how to setup a test case. I haven’t used Custom Permalinks. Feel free to submit a PR, but I may refactor it so use an action or filter so that the plugin is a general as possible.

    2. You can workaround this for now as you can customize with the revisionize_user_can_revisionize filter. But you’re probably right, edit_pages should probably be considered by default.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘2 Bugs’ is closed to new replies.