2.2.9 and Fix: Separate brands by comma

  • Resolved holle75

    (@holle75)


    1 year, 11 months ago

    Hi, adding a comma to separate brands in a list might be a good idea but:

    I worked hard to give every Brand a nice border, button style. The comma kind of destroys it. Would you be willing to make this comma optional in settings? Some might like it, others not. OR give the comma a proper class so we can hide it with css?

    btw: would be great to give the a href of pwb in archive loop under

    .pwb-brands-in-loop

    a class too ?? … and im wondering why the second, third brand has a span and the first one not? Or give the first one a span too? anyway classes would be nice for all of them.

    thank you!

    • This topic was modified 1 year, 11 months ago by holle75. Reason: boy, it′s a shame that Gutenberg is not working properly even on www.remarpro.com forum ;)
Viewing 12 replies - 1 through 12 (of 12 total)
  • Thread Starter holle75

    (@holle75)

    … just realize the whole loop

    .woocommerce-LoopProduct-link.woocommerce-loop-product__link

    under

    .pwb-brands-in-loop

    seems a bit strange?

    Thread Starter holle75

    (@holle75)

    something seems strange with

    public function show_brands_in_loop()

    in

    class-perfect-woocommerce-brands.php

    i have no idea where the double

    .woocommerce-LoopProduct-link.woocommerce-loop-product__link

    under

    .pwb-brands-in-loop

    is coming from?

    https://ibb.co/d078hCF

    Plugin Author quadlayers

    (@quadlayers)

    Hello @holle75

    We will remove comma separator and include this as an option

    We havent made any changes in classes, please compare with previous versions

    Thread Starter holle75

    (@holle75)

    point 1) good. Thank you.

    point 2) yes, i saw. That means this problem exist since longer. It also works since longer, but it′s ugly code, makes no sense (it seems to me, though) and when you want to style the brands you are running into complications that are unnecessary. The question is, what is the purpose of this garbled piece of code and why not fix it? Did you see my attached image?

    point x) anyways it would be nice to give thoses divs and spans and a href′s a nice class ?? … won′t break anything, would help people in the future.

    Thread Starter holle75

    (@holle75)

    Another humble suggestion: wouldn′t it be nice to link the images in products tab to the brand archive? As everywhere else. It seems it′s one line of code that needs to be altered. Thank you!

    Thread Starter holle75

    (@holle75)

    … to explain in more detail why i think classes for span, a, etc would be nice: usually it wouldn′t be a problem to touch all of them in the loop by

    .pwb-brands-in-loop a (or whatever)

    but due to the garbled code i mentioned you have to start with

    .xxxxxx a:nth-child (as an example)

    to catch all brand-links (and not the a in the garbled code). unsexy ??

    Please remove comma separators asap and include this as an option, it just destroys all the magic ??

    Thank you for your plugin!

    Plugin Support jmatiasmastro

    (@jmatiasmastro)

    @holle75 @ptm282192 Hello ! you can contribute with the modifications in the code of our plugin on github.

    We provide you a link below:
    https://github.com/franmastromarino/perfect-woocommerce-brands/pulls

    Regards, Matias.

    @jmatiasmastro and @quadlayers thank you for quick fix!!!

    Thread Starter holle75

    (@holle75)

    @jmatiasmastro. Pullrequests on github are too complicated for me. Can′t even get this one here nicely formatted.

    what i did in class-pwb-product-tab.php to public function product_tab_content() :

    edit: here was the code. Half of it gets eliminated by this very bad code block. Shame.

    edit2: https://codeshare.io/6p9L0Y (unfortunately only 24 hours), this one seems better: https://codefile.io/f/Gi9QZQiN7B0aDcQRndU2

    would love to show the suggested adjustments to class-perfect-woocommerce-brands.php but here it′s too hard to read.

    Edit2: will tomorrow

    but still i would be interested where this double loop in class-perfect-woocommerce-brands.php is coming from. I adjusted the classes, as i wrote above i do not know where this double loop is coming from.

    Plugin Author quadlayers

    (@quadlayers)

    Hello guys both issues has been addressed on 2.4.3

    Best regards

    Thread Starter holle75

    (@holle75)

    thank you

    Also this one?:

    “but still i would be interested where this double loop in class-perfect-woocommerce-brands.php is coming from. I adjusted the classes, but as i wrote above, i do not know where this double loop is coming from.”

    when this problem is fixed, i gladly modify the file again with classes and post it here.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘2.2.9 and Fix: Separate brands by comma’ is closed to new replies.