2.13.0 and the ‘Disable for’ setting not fully working

Hi @syntaxerrorno,

Did you double-check that the orders with Processing order status doesn’t have an invoice? If an order has already an invoice, the button will appear even if this order status is disabled. The logic behind this is that the Disable for setting is intended to avoid creating invoices in a specific order statuses, not to hide existing documents that you may need to view.

That said, if you have existing documents in orders with a disabled order status, this may be because you have set the Disabled for setting after you have created this document or this document is being created through another order status that is previously set, e.g. On hold. My recommendation is to select ALL those order statuses in which you don’t want to create an invoice and leave only the one(s) where it’s 100% safe to do it, e.g. Completed.

Yes, as stated it did work nicely before the update. No settings was changed, and they have no invoice no. Processing orders shouldn’t be invoiced after all, they are not at that stage, and that’s exactly why we use the ‘Disable for’.

Only thing changed on the site between working and not working was the update from 2.12.1 to 2.13.0

I can’t replicate the scenario that you have described. Could you please send me a screenshot of your invoices settings from WooCommerce > PDF Invoices > Documents > Invoice?

In addition, if possible, please send a screenshot from your order list too, displaying the action buttons, that can be activated from the Screen Options in the top right of the page.

Sure, where do you want me to send the pictures?

Anyhow I tested upgrading WP and Woo, no change.
Then I tried reverting back to 2.12.1, no change.
Updated to 2.13.0 again, no change.
Then I tried selecting the ‘Always use most current settings’, and boom, it suddenly disabled the action buttons etc.

Note! Probably should have mentioned it earlier, but WooCommerce PDF Invoices & Packing Slips Professional 2.11.0 is installed too, and I see no update for it. Nor does it change anything if I disable it …

Tested adding new orders after reverting back to 2.12.1, and the action button for invoice etc. is being hidden as it should.

Then tested adding new order using 2.13.0, and the action button was back.

No settings changed or re-stored in between.

One more test; Now adding a new order when having WooCommerce PDF Invoices & Packing Slips Professional 2.11.0 disabled, running only WooCommerce PDF Invoices & Packing Slips 2.13.0 – and it also works as intended.

So it seems like a conflict between 2.13.0 and the Pro version too me.

Thanks Rune, that’s useful information. I tried reproducing the issue with WooCommerce + free + pro but didn’t see the button for the disabled statuses. However, since you mention you don’t have this issue with the free version alone, we should take this to our paid support channel – www.remarpro.com does not allow us to use these forum for supporting our paid extensions. Please send an email to [email protected] (make sure to include your license key) and we’ll do our best to help.

OK, I’ll send you a mail as soon as I get time for it.

But regarding the free version, and anyway what we see, is it intentional that the disable setting etc. isn’t applying to already placed orders? All settings and general behaviour in the plugin only applies for new orders?

T.ex. if I placed an order when 2.13.0 was installed, the button displayed, and it still displayed on the old order after downgrading to 2.12.1. BUT it’s hidden for new orders placed with 2.12.1 active. That part didn’t make sense to me, and it’s also important to be aware of when testing.

is it intentional that the disable setting etc. isn’t applying to already placed orders?

not necessarily for placed orders, but for already created invoices, yes. The “disable for” setting prevents an invoice from being created when the order has a specific status, but it cannot prevent that an invoice could have been created before it reached that status. And our plugin never hides existing invoices.

So if your invoice is created (for whatever reason, manually, or automatically) when the order was still pending payment, disabling it for processing orders will not have any effect, because it was already created. This has not changed between 2.12.1 and 2.13.0.

I’m not talking about invoices here, but the display of the buttons for Processing orders who have not been handled in any other way than being placed by the customer, and updated to processing by the payment plugin.

Hi @syntaxerrorno,

This turn out an issue related with a new enhancement we added in 2.13.0. Since this version, we only store historical settings in the order meta, but this caused that non-historical document settings can no longer be read from the order once the settings have been stored. The latest release, 2.13.1, will fix the issue, since it recombines all non-historical settings with the order settings.

Could you please update your plugin to the latest release and confirm if it was indeed fixed?

Thanks,

I just tested it, and from what I can see it has been fixed in 2.13.1