• Resolved bjrnet21

    (@bjrnet21)


    Your latest version breaks on my site.

    Images don’t show up in footnotes.

    In the body after a footnote with an image, I get the following:

    2) alt=”BJRnet.com” width=”82″ height=”29″ data-popupalt-original-title=”null” /> alt=”BJRnet.com” width=”82″ height=”29″ data-popupalt-original-title=”null” />

    which was for the image in the footnote.

    The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Contributor pewgeuges

    (@pewgeuges)

    @bjrnet21

    Your images appear correctly to me in footnotes:

    https://ibb.co/nfNyTGV

    Why do you experience otherwise?

    Best regards,
    @pewgeuges

    Plugin Contributor pewgeuges

    (@pewgeuges)

    In the body too, the footnote referrers appear correctly, work correctly, and no undesirable code shows up:

    https://ibb.co/WgGZSc3

    But sorry, you (obviously) already reverted to version 2.1.3 of Footnotes. I’ll move to my sandbox testing your use case.

    • This reply was modified 3 years, 11 months ago by pewgeuges.
    • This reply was modified 3 years, 11 months ago by pewgeuges.
    • This reply was modified 3 years, 11 months ago by pewgeuges.
    • This reply was modified 3 years, 11 months ago by pewgeuges.
    Thread Starter bjrnet21

    (@bjrnet21)

    I have not updated footnotes on my main site.

    I use a staging site. This is what it looks on the staging site.

    https://static.bjrnet.com/images/test/Capture.JPG

    https://static.bjrnet.com/images/test/Capture2.JPG

    Notice that the images are NOT in the footnotes and image attributes are displayed on the web page.

    Plugin Contributor pewgeuges

    (@pewgeuges)

    Thank you for the screenshots! My suspicion is this: The new version of Footnotes adds some code around URLs that are not the value of an href argument, so as to make them line wrapping. Else the reference container expands and causes horizontal scrolling, or becomes partly invisible hanging out of the screen. Just catching link elements doesn’t do the job, because some URLs are not hyperlinked, and some links are normal language, that mustn’t be broken anywhere. Unicode-conformant user agents don’t need this fix, but Chrome does.

    So bad I didn’t think about images in footnotes. I’ll add ‘src=’ to the regex.

    My apologies for this new mishap! Really didn’t think about images.

    The bugfix shall roll out in a few minutes.

    Thank you for reporting this issue!

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @bjrnet21

    The release fixing this bug is now available. With me it works. Hopefully for you 2.1.5 does fix the issue.

    I apologize again for not catching the image use case on the first take.

    Thank you a lot for your quick feedback!

    Best regards,
    @pewgeuges

    Thread Starter bjrnet21

    (@bjrnet21)

    Just checked 2.1.5. It looks like your update did the trick. It fixed my issue.

    Thank you very much for your attention to this matter and your quick turn-around.

    Great plugin.

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @bjrnet21

    Thanks a lot for your feedback, for helping fix this bug, and for your appreciation!

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘2.1.4 Breaks on my site: Images don’t show’ is closed to new replies.