1.2.2 and wpml

Hello summoner,

There some changes done in 1.2.2 which are being reverted in 1.2.3 – but these are functional so I’m not sure how they would affect any translation process.

Could I ask you test out the Beta version and see if that resolve the issue for you? You can get a copy here: https://wpdefault.com/fourteen-extended-beta-1-2-3/

Thanks,
Zulf

I just tried 1.2.3 beta. Sorry, but the problem persist even if i deactivate all the plugins except wpml and fourteen-extended.

It really surprised me as i did not think the changes in 1.2.2 could affect it either. Right now i will revert to 1.2.1 i am pretty happy with that! I really find this plugin great!

It really surprised me as i did not think the changes in 1.2.2 could affect it either.

Likewise – but I’ll endevour to look in to it further to see what the deal is there.

Right now i will revert to 1.2.1 i am pretty happy with that! I really find this plugin great!

Glad its of use to you ?? – if I may suggest slight changing the name so that you don’t get the update nag/accidental update just to save you the hustle of having to keep on reverting back?

Regards,
Zulf

Hello again,

Today i had some freetime and tried to find the cause.
Using v1.2.2 i get 1 failure notice in the console:
“Uncaught TypeError: undefined is not a function jquery.flexslider-min.js?ver=3.8.1:6”

If i change line 387 in functions.php to use the non-minified version of the script then i do not get any failure notice.

Comparing the 2 scripts i found out the minified version is v2.2 while the non-minified version is v2.3-bleeding.

First i thought the problem is that these versions differ, but then i noticed that in v1.2.1 these scripts are the same. For some reason in v1.2.1 i do not get any failure notices in the console, however jquery.flexslider.js and jquery.flexslider-min.js were not changed in v1.2.2.

So i do not understand but perhaps there might be an unnoticed typo somewhere in the code of v1.2.2??

Same with v1.2.3 beta that has reintroduced featured-content.

If i overwrite functions.php of v1.2.3 beta with functions.php of v1.2.1 then all of a sudden the featured content will be translated again as awaited. So please review that file.

Hello and thank you for the detail feedback.

I’m releasing version 1.2.3 later today or tomorrow with some adjustments made from the Beta version. I hope that will do two things, (a) resolve the issue or (b) confirm that its a persistent issue requiring further investigation.

Once released if you could please test v1.2.3 and confirm either way so that I can start the debugging process in v1.2.4 I’d very much appreciate it.

I can confirm though that no changes we made to either of the js files in question and only feature rich functions were added to functions.php.

Once again thank you for your continual support as we develop this plugin further.

Regards,
Zulf

Hello again. Just updated to v1.2.3. Case b, that means problem persists.
Injecting functions.php of v1.2.1 solves it as before.

Compared the 2 functions.php files. If i comment out line 179 in functions.php of v1.2.3 to disable the function ‘fourteenxt_get_featured_posts’, then featured content will be translated as expected.

For now it seems the last few bits to change are located in this function ??

Well it seems it is just an issue of the order of tasks.
By modifying line 179

from
add_filter( ‘twentyfourteen_get_featured_posts’, ‘fourteenxt_get_featured_posts’, 999, 1 );

to
add_filter( ‘twentyfourteen_get_featured_posts’, ‘fourteenxt_get_featured_posts’, 1, 1 );

the featured content will be translated even if the function ‘fourteenxt_get_featured_posts’ is enabled.

Actually until 10, 1 everything is fine, from 11, 1 onwards it will not be translated.

Can you just think about whether changing task order like that could possibly affect other functions of the plugin? I just do not know other aspects of the code.

Good piece of feedback, thank you for that.

Its time to put that to test and see if we are ok or if we need to make other adjustments else where to accommodate it. Lets employ it in 1.2.4 Beta so we are all testing – the more the eyes the better the results ??

Regards,
Zulf