Upgrading to PHP 8.x leads to the following fatal error:
Uncaught TypeError: preg_match_all(): Argument #2 ($subject) must be of type string, array given in /wp-content/plugins/svg-favicon/inc/classes/models/PluginInfo.php:55
Do you have a fix for that?
thank you
]]>That would be great if favicon stayed after uninstalation of plugin.
]]>Hi,
I’m using your plugin with both SVG Favicon and Safari uploaded with correctly sized svg image.
Frontend I can see
<link rel="icon" size="any" type="image/x-icon" />
<link rel="mask-icon" color="#000000" />
<link rel="apple-touch-icon" />
which works perfectly for svg supported browsers as well as Safari.
However, when I tested using old Internet Explorer, there doesn’t seem to be a fallback and no favicon is displayed. I also don’t seem to see the image I uploaded through customizer in frontend page source.
Could you help? Thanks!
]]>Hello,
With the latest plugin release (version 1.2.5), it’s causing the website to crash.
Below are the error details running on PHP version 8.1.13.
Error Details
=============
An error of type E_ERROR was caused in line 55 of the file /home/psdg/public_html/wp-content/plugins/svg-favicon/inc/classes/models/PluginInfo.php. Error message: Uncaught TypeError: preg_match_all(): Argument #2 ($subject) must be of type string, array given in /home/psdg/public_html/wp-content/plugins/svg-favicon/inc/classes/models/PluginInfo.php:55
Stack trace:
#0 /home/psdg/public_html/wp-content/plugins/svg-favicon/inc/classes/models/PluginInfo.php(55): preg_match_all(‘/\\* version:\\s+…’, Array, NULL, 2)
#1 /home/psdg/public_html/wp-content/plugins/svg-favicon/inc/classes/models/PluginInfo.php(86): FOF\SVGFAVICON\Models\PluginInfo->getVersionNumber()
#2 /home/psdg/public_html/wp-content/plugins/svg-favicon/inc/classes/admin/AdminSetup.php(28): FOF\SVGFAVICON\Models\PluginInfo->version()
#3 /home/psdg/public_html/wp-includes/class-wp-hook.php(308): FOF\SVGFAVICON\Admin\AdminSetup->enqueueAdminStyles(‘appearance_page…’)
#4 /home/psdg/public_html/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters(NULL, Array)
#5 /home/psdg/public_html/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#6 /home/psdg/public_html/wp-admin/admin-header.php(118): do_action(‘admin_enqueue_s…’, ‘appearance_page…’)
#7 /home/psdg/public_html/wp-admin/admin.php(239): require_once(‘/home/psdg/publ…’)
#8 /home/psdg/public_html/wp-admin/themes.php(10): require_once(‘/home/psdg/publ…’)
#9 {main}
thrown
Thanks for your time reviewing this.
]]>Hello,
I am getting the following in my error.log:
PHP Warning: Undefined array key 0 in /home/USER/public_html/wp-content/plugins/svg-favicon/inc/classes/models/PluginInfo.php on line 55
Here’s line 55:
preg_match_all($re, $comments[0], $matches, PREG_SET_ORDER);
Hello,
I see the following PHP Warning on sites where I have installed this plugin:
PHP Warning: The magic method FOF\SVGFAVICON\Traits\Singleton::__wakeup() must have public visibility in /home/xxx/public_html/wp-content/plugins/svg-favicon/inc/classes/traits/Singleton.php on line 11
Is this something that can be addressed in a future update?
Thank you!
]]>Hello, thans for plugin!
But I have this error in w3c validator
<link rel=”icon” href=”https://mysite.com/wp-content/uploads/svg_favicon/svg-favicon.svg?svg-favicon=2022-05-11T15:22:01+00:00″ size=”any” type=”image/x-icon” />?<link
Error: Attribute size not allowed on element link at this point.
]]>Hi!
I just loaded my favicon, that is a signature (black on transparent background)
My wondering is how to deal with black mode? When chrome tabs are black my favicon does not show, because is black on black…there is any way to invert the colors for dark mode?
thanks!
]]>Hi! Can you make instruction – how make mask for safari? I know very little about an illustrator. I don’t understand what exactly needs to be done for the safari.
Thanks!