I’m not able to test this plugin further but I have made the suggested changes. If you are able to test this plugin please let me know what you find and any corrections you might be willing to contribute.
Thanks
]]>I noticed the following.
Function ereg() is deprecated in /data/rddotcom/wp-content/plugins/ie6-upgrade-option/ie6-upgrade-option.php on line 127
Proposed fix:
$browser = strtolower($_SERVER['HTTP_USER_AGENT']);
if ( stripos( $browser, "msie" )) {
$plugin_dir = basename(dirname(__FILE__));
load_plugin_textdomain('ie6option', 'wp-content/plugins/' . $plugin_dir, $plugin_dir );
$obj_ie6option = new ie6option();
add_action('wp_footer', array($obj_ie6option, 'add_footer'));
}
Original:
$browser = strtolower($_SERVER['HTTP_USER_AGENT']);
if(ereg("msie", $browser)){
$plugin_dir = basename(dirname(__FILE__));
load_plugin_textdomain('ie6option', 'wp-content/plugins/' . $plugin_dir, $plugin_dir );
$obj_ie6option = new ie6option();
add_action('wp_footer', array($obj_ie6option, 'add_footer'));
}
]]>
As above in topic.
Please update.
]]>There are several errors in the CSS.
On line 166, color: #CCA329; !important
should be color: #CCA329 !important;
(the semicolon should be after !important
). There is also an unnecessary asterisk on line 22.
There are also several places where there is an unnecessary space between a colon and the psuedo-class. E.g. : visited
instead of :visited
. This may work in some browsers, I don’t know, but it gives errors in FireFox 18, causing those sections to be ignored. They are on the following lines: 52, 53, 54, 58, 116, 117, 121, 122, 183, 184, 190, 191, 233, 250, 251, 258, 259, 273, 278.
There is also a block that is commented out, and should probably just be removed, unless those images are going to be included with the plugin, in which case the styles should be modified to point to the path of the included images. (on lines 142-152)
Other than that, great plugin!
]]>Try to download this plug in and the wordpress says ( this plugin has invalid header.
]]>Is this possible with this plugin? If so, how might it be done? Thanks!
]]>When I try to activate the plugin I got the error:
]]>The plugin does not have a valid header.
Hi,
I sent you the translation in Portuguese!!!
I just installed in a new WordPress and the plugin just come in English when I test.
Maybe something is broken…..
Thanks very much!
]]>After clicking continue anyways and moving to another page in IE6 the pop-up warning often shows up again. Is this a browser cookie issue?
FYI The browser shortcuts inside the pop-up do not work for me in Internet Explorer 6 until I allowed pop-ups.
]]>After clicking continue anyways and moving to another page in IE6 the pop-up warning shows up again. Is this intentional or is this a browser cookie issue?
FYI The browser shortcuts inside the pop-up do not work for me in Internet Explorer 6 until I allowed pop-ups.
]]>Thanks for the plugin!
How do I remove the download link to IE8 all together? I prefer that my users use any browser other than IE8.
]]>