Hi! I’m very interested in using your plugin, but can’t use Gutenberg/blocks. I just tested it with Classic Editor activate, and it seems Better Core Video Embeds doesn’t work without Gutenberg.

Any plans to add support for Classic Editor’s embeds?

The default CSS for the button alignment says –aspect-ratio-height and -aspect-ratio-width are not defined, and the play button sits at the top of the image. I’m using a Vimeo video with a custom thumbnail and have checked on multiple browsers.

top: calc(((var(--aspect-ratio-height) / var(--aspect-ratio-width))* 50cqw) -(0.5* var(--hd-play-button-size)));

Have you considered this simpler approach? The transform property moves the element back up by 50% of its own height and left by 50% of its own width.

top: 50%;
left: 50%;
transform: translate(-50%, -50%);

Captions seem to render as static text prior to the Block transforming, the markup should reflect the native <figcaption> markup to make sure the blocks styling is carried through regardless of the Blocks state.

Love this plugin. Has it been tested with WordPress 6.5?

Not sure why but when developing offline e.g. local, xamp, etc.. this plugin slows down site loads from 100ms to 7sec. Disabling the plugin fixes the issue. Wondering if this has adverse effect on a live server.

Hi, have lines and lines and lines with this error in my PHP errorlog:

[03-Apr-2024 11:15:27 UTC] PHP Warning: getimagesize(https://img.youtube.com/vi/0BvGN2xq0H8/mqdefault.jpg): Failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in [webhost path here*]/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 598

* removed the path as it happens on both of my blogs where I embed YT videos.

=> https://img.youtube.com/vi/0BvGN2xq0H8/mqdefault.jpg is the default image for an empty preview image.

After updating plugin to 1.3.1 version I have a warnings on page (see link).

Warning: DOMDocument::loadHTML(): Tag figure invalid in Entity, line: 2 in /home/surfatla/public_html/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 288

Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ‘;’ in Entity, line: 3 in /home/surfatla/public_html/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 288

Warning: DOMDocument::loadHTML(): Tag figure invalid in Entity, line: 2 in?/home/surfatla/public_html/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php?on line?288

Could you assist me to resolve this, please.

thanks,

Tibor

As a French speaker, I use é à è ? in some captions…

When the video is rendered on the site, all these extended chars are not properly interpreted.

example:
“Générique Temps X, présenté par les frères Igor et Grichka Bogdanoff” becomes
“G??n??rique Temps X, pr??sent?? par les fr?¨res Igor et Grichka Bogdanoff”

This happens with other characters too.

If the plugin is deactivated, the proper caption appears.

I am getting this error in my logs regarding the plugin but it seems to work fine. Anything to worry about?

2024/01/29 10:51:42 [error] 254#254: *5308 FastCGI sent in stderr: “PHP message: PHP Warning: Undefined array key “query” in /www/motorsportprospects_329/public/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 143″ while reading upstream, client: 51.222.253.6, server: https://www.motorsportprospects.com, request: “GET /sim-racing-gives-you-a-platform-to-raise-your-racing-skills/ HTTP/2.0”, upstream: “fastcgi://unix:/var/run/php8.0-fpm-motorsportprospects.sock:”, host: “www.motorsportprospects.com:42483”

2024/01/29 09:16:23 [error] 254#254: *4677 FastCGI sent in stderr: “PHP message: PHP Warning: Undefined array key “query” in /www/motorsportprospects_329/public/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 143PHP message: PHP Warning: Trying to access array offset on value of type null in /www/motorsportprospects_329/public/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 402PHP message: PHP Warning: Attempt to read property “thumbnail_large” on null in /www/motorsportprospects_329/public/wp-content/plugins/better-core-video-embeds/better-core-video-embeds.php on line 402″ while reading response header from upstream, client: 52.167.144.216, server: https://www.motorsportprospects.com, request: “GET /post-sitemap2.xml HTTP/2.0”, upstream: “fastcgi://unix:/var/run/php8.0-fpm-motorsportprospects.sock:”, host: “www.motorsportprospects.com:42483”

I’ve just noticed that the play button doesn’t vertically align as intended in Safari (15.6.1), it sits at the top of the video block, horizontally centered. This is occurring on several sites I manage.

For now I’ve just modified the CSS to this, which appears to work (though I’ve not applied it to the page I’ve linked to, so you can see the issue):

.hd-bcve-wrapper .play-button {
top: calc( 50% - ( 0.5 * var(--hd-play-button-size) ));
}

It seems Safari may be struggling with the calc.

Hi, I’ve been using this plugin ever since I first saw it a while back, it’s a great solution for fast loading videos, thank you.

I’m having some issues with thumbnail sizes though. I’m currently in the process of launching a newly updated client site which has several videos on various pages. Most of them are pulling in a maxresolution thumbnail image, typically 1280 x 720.

However, 2 of them are pulling in mqresolution thumbs at 320 x 180px, despite the videos displaying on the page at twice those dimensions. I’ve uploaded a correctly sized (1280×720) custom thumb for one of these videos and set it as the default, but it continues to display at 320px which looks pretty bad.

Is there anything I, or you, can do about this? This thread on stackoverflow seems relevant but I’m not that much of a coder: https://stackoverflow.com/questions/34763547/youtube-maxresdefault-thumbnails

I can’t share a URL right now as I’m literally in the middle of launching the new site, but will be able to soon if necessary.

• This topic was modified 1 year ago by Jaiji.

Hi,

Love the plugin and appreciate that you have only extended the core block. A couple of thoughts. Right now, the video is not accessible. There’s no way to navigate or interact with it since it’s just an image and a div. One simple change would be to change the div to a button ( I know this will require a bit of extra CSS), that way, someone using a screen reader and keyboard can trigger the video. It would also be good to provide a label for the button, either via an aria-label or a span with screen-reader-text class.

Current Button

<div class="play-button"></div>

Updated Button

<button class="play-button" aria-label="Play Video"></button>

<button class="play-button"><span class="screen-reader-text">Play Video</span></button>

In an ideal world it would be great to extend the block to add a custom field to the settings for a video title ( avoid the need for api calls ) and then that could be appended to the “Play Video: …. ” text.

Without plugin:

With plugin, player show:

Oops! The embed code for this video is not valid

Console:

GET https://player.vimeo.com/video/791829200&rel=0&showinfo=0&autoplay=1 404 Not found

Since the video and scrips are not loaded until user clicks on the image does this mean that it is in balance with GDPR laws?

Hello,

the plugin really is great, thanks for putting it together. Just by accident, I found that when putting the link to youtube like this: https://youtube.com/watch?v=whatever (without www), the block will not be replaced.
I found that in the switch statement hd_bcve_render_core_embed_block, you have only the case ‘www.youtube.com’. I don’t see a reason why you couldn’t also add youtube.com without www? Knowing that it only works with www, I can just always add it, but for less techy users this behaviour might come as a surprise. https://youtube.com and https://www.youtube.com are both valid and should both work.

• This topic was modified 1 year, 10 months ago by mrksdiehl.
• This topic was modified 1 year, 10 months ago by mrksdiehl.

Hi,

A quick remark relating to SEO: the images that replace videos don’t have an”alt” tag. Don’t know if it’s possible to create one from the video, e.g. injecting it’s title (stripped of any bad characters just in case).

Sincerely
DJM

The basic idea is great, but the CSS isn’t loading, so there is no default “play” button being displayed. Also, you might want to add a width:100% to the inserted image, in case the size returned from YouTube etc. isn’t 100% of the replaced FIGURE.