"current_menu_item" class on menu not working in BB

Hey Swayam,

Thanks for posting! Are you targeting current_menu_item? Because it’s actually current-menu-item. I have just tried it on my end and I can see the class added to the menu item if I’m on the page it links to. Can you check? If it still doesn’t work, can you share the URL of the site in question so we can take a look?

Ben

yep sorry its “current-menu-item” class, when i use custom link for about page in menu (if I put link directly) then it just works fine, but if i use page “about” to add in menu then it won’t works, below is the code i used to render my header template

FLBuilder::render_query( array(
	'post_type' => 'fl-builder-template',
	'p'         => 72
) );

I cant give you link right now as the site is not publicaly available, do you think am i missing anything ?

Sorry Ben, i have explained it wrong, it’s working when we use Menu module, but for header, i have developed my own custom module and save it as template, my module uses “wp_nav_menu” function for renderring menu, not sure what’s wrong or i need to check default Menu module how its working, is there any way we can call default by passing which menu we need to show ?

Can you share the URL of the page in question so we can take a look?

Ben

Here is the link, you can check for pages like FAQ, about its not working, while for blog, contact its working as i have added custom links in menu, please check & instruct me what i am doing wrong ?

Hey Swayam,

Our lead dev checked in on this and it seems the issue is coming from the fact that you’re calling the menu via template. If you use a Page/Post item on the menu, it checks for the post ID it is in, and if it returns true, it adds the current-menu-item class. However, on your case, the menu is seeing the template as the current page instead of the actual page, so it returns false every time.

Custom links on the other hand, checks for the URL it is in, instead of the post ID, and is the reason why it works. We’d suggest just using custom links on your menu template.

Hope this makes sense. ??

Ben

Hey Ben,

Thanks for replying, so it means that it will not work when we use menu inside template ? is there any solution for that because i am using templates for header & footer and for client it will be problematic to put custom links all the time, the reason why i am using it as a template that it will be easy for client too to change anything in layout.

Swayam

Hey Swayam,

Our lead dev already took a stab at fixing this for our 2.0 release but seeing as it’s an issue with how wp_nav_menu works, it’s not an easy fix. Just letting you know it’s on our radar though! And thanks for the heads up! ??

Ben

Thanks Ben, really appreciate your efforts on this, i will check for this issue if it resolves in future upgrades or i will take some other alternative.

No worries at all, Swayan! You can check our Change Logs for update enhancements/fixes. ??
https://www.wpbeaverbuilder.com/change-logs/

Ben

Hey Ben,

I have found some temporary work around for this issue.

Thanks.

Hey Swayam,

That’s good to hear! Do you mind sharing what it is so we can share it in case another user encounters the same thing? Or perhaps we can make a solution out of it? ??

Ben

yep sure, what i did is, before calling wp_nav_menu function, stored global $post variable in a temp variable and reset query, so it now points to the page which i am on and not the header template

global $post;
$temp = $post;
wp_reset_query();

and then after wp_nav_menu, i have set the $post again.
$post = $temp;
Complete code below

global $post;
$temp = $post;
wp_reset_query();
// Displays WordPress navigation menu dynamically
$args = array('menu'=> $menu_name,'menu_class' => 'head_menu nav navbar-nav color02','container' => false,'walker'=> new wp_bootstrap_navwalker());
wp_nav_menu($args);
$post = $temp;

Hoping for a permanent solution for this ??

Hey Swayam,

Just letting you know our lead dev already checked the code you have above, but would need to test it more before implementing it, if ever.

Anyhow, thanks for sharing your solution! We really appreciate it. ??

Ben

I just came across this issue, any chance of a future fix for this? I just opened a support ticket on your website but meanwhile figured it must be a template related issue and then found this thread.

I can place a menu using a different method but as Swayam said it is nice to use the templates for a header, allows easy editing and styling for a client.