Feature request: Notify Once Only

Hi CK MacLeod,
Thanks for your message.

This functionality isn’t currently available in the plugin however, I like the idea and can add it to the roadmap.

So, are you saying you want a feature that only enables a notification being sent once for each notification set up and for each post/page/custom post type?

Thanks,
Jack

I don’t need to tell you how complicated you could make a seemingly simple change like this one! So, I’ll stick to the simple case.

Since we’re using a second email users add-on, the Notify Users functionality that’s part of Email Users, we’d probably just turn on a global Notify Only Once (NOO) for Review and Scheduled if available. We might add it to Updated, if we enabled Updated (no current plans for that).

I don’t think there are any or many other automatic notifications that NOO would apply to logically. Being able to restrict it or turn it off for certain categories or post types, or on or off on a post-by-post basis, might be nice for some set-ups.

I think that most practical at least for us, and in keeping with the general design of your plug-in, would be an option to make NOO the default systemwide for affected/selected notifications types, on a main Settings Page checkbox or set of checkboxes, and, depending on those settings, to make them re-adjustable per Notification when added or edited.

More simply, but not having looked at the code, so only speculatively: If I were hacking the plug-in just for our purposes, I’d add post-meta scheduled_notified and review_notified variables that had to be false (default state) for a notification actually to be sent, and, obviously, flipped to true when the notification was sent. For making a more flexible plug-in, the rest ought to be straightforward depending on how far you want to go. If this isn’t something you’re likely to get to soonish, I’ll probably go ahead and see what I can do, then deal with future updates as they come.

Thanks CK MacLeod for clarifying.
It sounds like a good idea to me.

I’ve added it to the roadmap.

Thanks and I hope you enjoy using the plugin.
Jack

This seems to be working for now. Because your code is so clean and well organized, it was pretty easy.

/***********************
*** NOTIFY ONLY ONCE ***
* HACK OF BETTER NOTIFICATIONS FOR WORDPRESS
* originally lines 217 - 245 in bnfw.php
***********************/

	/**
	 * Fires when a post is pending for review.
	 *
	 * @since 1.1
	 * @param int $post_id Post ID
	 * @param object $post Post object
	 */
	function on_post_pending( $post_id, $post ) {
		$post_type = $post->post_type;
//NOTIFY ONLY ONCE HACK	= First, Second, and Fourth of Next Four Lines
		$pending_notified = get_post_meta($post_id,'_bnfw_notified_pending',true);
		if (( BNFW_Notification::POST_TYPE != $post_type ) && ($pending_notified != '1' ) ) {
			$this->send_notification( 'pending-' . $post_type, $post_id );
			add_post_meta($post_id,'_bnfw_notified_pending','1');
		}
	}

	/**
	 * Fires when a post is scheduled.
	 *
	 * @since 1.1.5
	 * @param int $post_id Post ID
	 * @param object $post Post object
	 */
	function on_post_scheduled( $post_id, $post ) {
		$post_type = $post->post_type;
//NOTIFY ONLY ONCE HACK	= First, Second, and Fourth of Next Four Lines
		$scheduled_notified = get_post_meta($post_id,'_bnfw_notified_scheduled',true);
		if (( BNFW_Notification::POST_TYPE != $post_type ) && ( $scheduled_notified != '1' ) ) {
			$this->send_notification( 'future-' . $post_type, $post_id );
			add_post_meta($post_id,'_bnfw_notified_scheduled','1');
		}

Feel free to improve it!

Wow! Thanks CK MacLeod!
I’ll investigate adding it to the plugin for the next major version.

Thanks again and remember, if you like the plugin, please feel free to leave an honest review.
Jack

please feel free to leave an honest review.

Thought I’d already done that! Will make sure I do.

As for the code, as you can see, it’s pretty simple – even rough and a little primitive – but I’ll take the compliment anyway, and look forward to see what you do with it.

Has this been added in yet? I’m going to add the code myself, but would love to know if this has been incorporated into the plugin or is planned soon.

Hi JohnArcadian,
Thanks for your message.

No, this hasn’t been added in yet but it is on the roadmap.

Jack