HTML5 Pushstate for query Strings in search

We hardcode the state variable https://github.com/Automattic/WP-Job-Manager/blob/52737168efe0a14b7e3dfd1169ad563de1f8659c/assets/js/ajax-filters.js#L265 I don’t see any benefit to changing it?

It’s implemented to fix back button functionality, not to page through results. I’ve not looked into this and the core script would need modifying.

3 you can do. update_results event or ajaxcomplete.

We hardcode the state variable https://github.com/Automattic/WP-Job-Manager/blob/52737168efe0a14b7e3dfd1169ad563de1f8659c/assets/js/ajax-filters.js#L265 I don’t see any benefit to changing it?

I want to track the searches using google analytics so need the specific query strings in the url before I call the analytics state and add a page view.

I also want users to be able to share specific searches and other people will see the same thing when they click on the link.

3 you can do. update_results event or ajaxcomplete.

What are the extra paramaters that I am passing to update_results [1, false] is there any documentation on this that I could save for reference later?

Can I make these patches myself and submit pull requests (whats the correct repository if I want to do this)?

update results is a trigger – you don’t pass anything. https://github.com/Automattic/WP-Job-Manager/blob/master/assets/js/ajax-filters.js#L5

https://api.jquery.com/trigger/

there are some extra parameters in an array [1, false] passed to the trigger function.

You’re listening for the trigger, not triggering anything.

Ok I understand.

In the ajax-filters.js there is an event listener for the update_results event.

When I write a custom trigger like so
someElement.trigger('update_results', [page, append, loading_previous]);

Where:
page is some integer value setting current page of results
append is a boolean setting whether to keep current results
loading_previous is optional value (if append is set to true) and decided whether to put the new results under or above the original results.

I have forked and am writing a patch to set up the behaviour I need,
https://github.com/lindsaymacvean/WP-Job-Manager/commits/master

Hopefully you can do an interactive rebase on my commits and they will be durable enough to pull back into the master branch.

I have two questions:

Whats the purpose of updated_results event (it doesn’t seem to trigger anything)?

Is there a basic assumption that there is only one ajax form per page?

At the moment I am stuck on a bug when I click the back button it doesnt refresh the results with the correct result in the history. I will continue to work on it.

Ok I have submitted a pull request. Please let me know if I have missed the point of anything, or need to make any bug fixes.

https://github.com/Automattic/WP-Job-Manager/pull/520

Thanks I’ll review this ??

Hey Mike,

Any luck on this. Just let me know in a few words if my patch has any likelihood of being accepted or if there are other considerations that exclude it from a merge, and perhaps there is something I can do.

Warmest regards,
Lindsay

Hey Mike,

bump. ??

Warmest Regards,
Lindsay

Mike’s on vacation right now until Oct 5th. It’s an open PR though, so please use that from now on for discussion.

Thanks!