Broken Dependencies

On further inspection, it seems like when your code is active, it’s removing all of acf’s client side form validation. With your code active, it stops at the php validation instead. I also briefly see a Script error in console, but it goes so fast I don’t get a chance to see it.

Hi @lagdonkey,

Can you let me know the specific version of ACF you are using and the code you are using to include it and the Validated Field plugin? The version of PHP, webserver, and browser you are using would be helpful as well.

In the latest version of the plugin – which it looks like you are using – the only JavaScript that is included is for the jQuery Masked Input. The other JavaScript you are seeing in input.js is for ACF4, and field-group.js was removed when the version of ACF is greater than 5.2.6 (the latest version of ACF is 5.2.9).

Can you check to see if there are any errors in your PHP error log?

Wow, thanks for the fast response. I’m using ACF 5.0, and 1.7.7 of your plugin. I’m using the latest build of Chrome. Nothing in php error logs pertaining to this. The 2 JS files I see it’s loading from your code are
field-group.min.js and jquery-maskedinput.min.js. It wont actually load your plugins input.js file, unless I remove the dependency parameter within your code (validated_field_v5.php)

wp_register_script( 'acf-validated-field-input', plugins_url( "js/input{$min}.js", __FILE__ ), array( 'acf-validated-field' ), ACF_VF_VERSION, true );

on line 1145

Sent too soon. As for webserver, just a generic apache server, running php 5.4.

That looks like sloppy code on my part, but it shouldn’t actually use the file since it isn’t enqueued anywhere. I’ve update the functions on the dev version to look like the following, but I suspect it won’t fix your issue:

function input_admin_enqueue_scripts(){
		// register acf scripts
		$min = ( ! $this->debug )? '.min' : '';
		wp_register_script( 'jquery-masking', plugins_url( "js/jquery.maskedinput{$min}.js", __FILE__ ), array( 'jquery' ), ACF_VF_VERSION, true );

		// enqueue scripts
		wp_enqueue_script( array(
			'jquery',
			'jquery-ui-core',
			'jquery-ui-tabs',
			'jquery-masking'
		));
	}

function admin_head(){
		global $typenow, $acf;

		$min = ( ! $this->debug )? '.min' : '';
		if ( $this->is_edit_page() && "acf-field-group" == $typenow ){
			wp_register_script( 'acf-validated-field-admin', plugins_url( "js/admin{$min}.js", __FILE__ ), array( 'jquery', 'acf-field-group' ), ACF_VF_VERSION );
		}
		wp_enqueue_script( array(
			'jquery',
			'acf-validated-field-admin',
		));
		if ( version_compare( $acf->settings['version'], '5.2.6', '<' ) ){
			wp_enqueue_script( 'acf-validated-field-group', plugins_url( "js/field-group{$min}.js", __FILE__ ), array( 'jquery', 'acf-field-group' ), ACF_VF_VERSION );
		}
	}

Are you seeing this error in the field group editor or on the actual post when you try to validate a field?

Well as I said, within the field builder (custom fields), adding the field, I have to save and load before the actual validated field select populates. I see the broken dependency message when I’m in the post editor, editing the post that has the field in it.

My guess is, it’s a missing JS file causing both issues, but damned if I can figure out why. The rest of acf itself works fine (short of the validation client side, but my guess is that somethings trying to make a call to the missing file, which is tripping a JS error which is causing the client side validation to fail).

As far as I can tell, I have all ACF files loaded properly, so I don’t think it’s anything to do with ACF itself.

wp_enqueue_script( array(
            'jquery',
            'jquery-ui-core',
            'jquery-ui-tabs',
            'jquery-masking',
            'acf-validated-field',
            'acf-validated-field-input',
        ));

Starting on 1133. What script should ‘acf-validated-field’ be?

You can remove both:

'acf-validated-field',
            'acf-validated-field-input',

There shouldn’t be any client side validation in ACF5, it is all done server side. This is why I am no longer returning JavaScript files other than the masked input (since that is client side) and the admin.js to add things like the field editor, and that’s really to control the UI not the submit.

My guess it’s related to how you are including it in your plugin (whether you are doing it correctly or not). I have a test site running the latest WP and ACF with not much else and it is working fine…

ACF5 does have client side (JS, via ajax) validation, for required fields etc. Usually it throws an error and wont submit. But in this case, its posting and I’m seeing php validation errors instead. I’m wondering if it, in fact is, how I’m registering acf. I’m doing it correctly, but due to Plugins loading in alphabetical order through WP, I’m wondering if that’s what causing it (My plugin is Aideed Events Manager) which would load AFTER your plugin.

I’ll play around and see what I can come up with. Thanks so much for taking the time to work on this. While we’re talking, I was wondering if you’d have a problem with me utilizing your code in my plugin. I likely will be maintaining a free copy here, as well as releasing a premium version down the road. Of course if you’re okay with that, I’d give proper attribution to you as the author ??

Quick update, removing those 2 lines fixed the validation issues, and now the fields save. Still the issue where I have to save before the validated field will populate, but that’s a trivial issue to me anyways ??

ACF5 does, but Validated Field does not – it just hooks into the default server side validation – my point being that it is unlikely there is a JavaScript conflict from the Validated Field plugin. If you are talking about the Field Editor and not the Post Editor that is a different story as admin.js is used to implement the admin side functionality in the Field Editor.

Plugins do not necessarily load in alphabetical order, they load based on the order of the array stored in your site options. They key used is either “active_plugins” or “active_sitewide_plugins” depending on if you are using MultiSite or not. If you want to control the load order of plugins, you can check out some code I wrote for “must-use plugin” type functionality, but in a standard plugin (so that it can be disabled, etc). Check out the function load_this_plugin_first() on this page: https://justinsilver.com/technology/wordpress/wordpress-plugins/wordpress-plugin-custom-functions-php/.

Great that you were able to resolve those issues. It’s weird that they were causing a problem for you and not myself (or others presumably since there are no support requests), but in any event it has been removed from my code as well since it should have been removed with the update to ACF5 anyway.

As for using my plugin inside your plugin – I don’t have a problem per se, but I do have some concerns about how updates would be made. I am currently working on version 2.0 of Validated Field (validate user fields, some bug fixes, code cleanup, new filters/actions, support for premium enhancements) and it would be a shame if your users didn’t get the latest. Would prompting the users to install Validated Field work instead or do you want to simplify? It might be best to take this discussion offline (I have some questions regarding the premium version of your plugin as well). Would you mind sending me an email at jsilver at my username dot com?

I do have some insight on your last issue, though I may not necessarily have any answer for you…

Thanks!

Great, I’ll drop you a pm and mark this as resolved.

Another update. So I had thought my issue was resolved, but it turns out that wasn’t the case. However, I FINALLY managed to trace the issue to this:

if ( version_compare( $acf->settings['version'], '5.2.6', '<' ) ){
            wp_register_script( 'acf-validated-field-group', plugins_url( "js/field-group{$min}.js", __FILE__ ), array( 'jquery', 'acf-field-group' ), ACF_VF_VERSION );
        }

As soon as I removed that, ACF client-side validation resumed working as it should, and input masking still works.

You are using exactly version 5.0.0 of ACF? It’s possible that the fix I made affected earlier version of ACF as well, but I believe it was somewhere in the 5.x stream. I can update the plugin, but out of curiosity, why are you not using the latest version of ACF?

I’m still having this issue – and have the latest version of ACF and your plugin. What was the resolution?