Order and invoice links in emails

What do you mean with not working? Isn’t there any link, is the page blank?

How does the link look like? Can you post one (without the domain)?

Thanks to pay attention to my post.

The link exist but when using it, the screen is blank in browser.

In the order mail (when order pass in ?processing? status, I have that link below which runs correctly:
https://mysite.com/mon-compte/print-order/1385/[email protected]

In the command completed mail (when order pass in ?terminated? status, I ?see? that link below which don’t run and give me a blank screen?:
https://mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&[email protected]

But in the web browser with the blank screen, the address is changed and is shown as?:
https://mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&print-order-email=namecustomerdomain.fr
….with https instead of http, and the address mail not correct?with the @ missing.

Moreover I get correctly the invoice screen if I enter directly the link below in my browser?:
https://mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&[email protected]
It seems as if there were a special data in place of the @

It seems that the ?Open print view in browser? link issue in emails happen when using a https?site : a http link is generated in place of a https link.
I succeed to get a correct link when forcing https in class-wcdn-theme.php line 111. Replacing ??else : ?>?? by ? else : $url = str_replace( ‘https://’, ‘https://’, $url ); ?>??.
But I wait for the academic update from piffpaffpuff.

hi there, thanks for the links and info. could you please install 4.1.5 and check if the issue is fixed?

btw: which ssl plugin do you use?

The situation with 4.1.4 was
1) link in mail Order received : https://mysite.com/mon-compte/print-order/1385/[email protected] =>OK
2) Link in mail from note admin : https://mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&[email protected] =>NOK
3) link in mail Order completed : https://mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&[email protected] =>NOK

The situation with 4.1.5 is
1) link in mail Order received : mysite.com/mon-compte/print-order/1385/[email protected] =>NOK
2) Link in mail from note admin : mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&[email protected] =>NOK
3) link in mail Order completed : mysite.com/mon-compte/print-order/1385/?print-order-type=invoice&[email protected] =>NOK

My SSL use is :
1) in settings of Admin / Woocommerce / Orders, a) I force https when entering payment pages, and b) I force http when going out
2) in settings of my plugin Itheme Security, a) I disable a general SSL for front end, b) I enable SSL when serving login and 3) when serving Dashboard.

To be sure, I did in 4.1.5 another test keeping Woocommerce SSL settings, but after desactivating the Ithemes Security Plugin : It give the same NOK results (no https in links).

I hope this may help.

PS : I post an update of the french translation in Github

@harasse thanks for your feedback. that is really weird. am i reading this right, that in 4.1.5 the links neither begin with http nor https?

i think the problem is that you use ssl only for the login but not the admin. this means i have no possibility to find out it the “My account” page should use https or http. and the email links need the account page.

did you try to print an order from the “My Account” page, does that work for you?

could you please download the latest version from github and test again? https://github.com/piffpaffpuff/woocommerce-delivery-notes/archive/master.zip

Sorry, I was not clear enough. In 4.1.5 the links begin with https:// .

1) Admin is always in ssl mode because I pass through the login proc which force SSL on.
2) Yes I can print an invoice from the “My Account” page of the customer as from the Admin panel.
3) Perhaps the issue come from the “no forcing http when going out” in woocommerce : this may change the SSL context for the customer after he has logged off.

4) I will do this day the other tests you ask for, and 2 more : one with no forcing http when going out of the user login in Admin / Woocommerce / Orders, and one by generating an Admin note with the customer still login from another PC.

I did some tests with 4.1.6 and Ithemes desactivated ; that is to say that only woocommerce SSL settings have to be considered.

1) link in mail Order received (Woocommerce settings : forcing https when entering payment pages, and forcing http when going out):
https://mysite.com/mon-compte/print-order/1545/[email protected] and link run is OK

2) Link in mail from note admin :
https://mysite.com/mon-compte/print-order/1545/[email protected] and link run is NOK

3) After disabling force http when going out, generate link in mail from note admin :
https://mysite.com/mon-compte/print-order/1545/[email protected] and link run is NOK

4) After disabling force http when going out, and keeping customer connected (https) on another PC, generate link in mail from note admin :
https://mysite.com/mon-compte/print-order/1545/[email protected] and afterward link run is NOK

Thanks for your tests. I have another idea what could cause the problem but i have no fix yet. I’ll keep you updated.