Plugin took down website

Hello,

Yes, you can access the custom functions data that the plugin had saved.

For this, in my-custom-functions.php file, find this line of code:

anarcho_cfunctions_exec();

and comment it by placing two slashes( // ) in beginning.

Then you can again activate plugin and take it from plugin page.

Thanks! As it turns out, I pulled it from the MySQL database. Had to do a little searching but I found it. Turns out there was some errant code. Just so happens your plugin allowed it to go through which caused the issue. So your plugin didn’t cause the issue, the code did. But the plugin’s code-check is not fool-proof so I’ll be more careful.

Can you show the code which caused the error?

Basically I had a gettext function ending with this:

add_filter( ‘gettext’, ‘ee_change_ticket_messaging_registration’, 10, 3 );

and added a second similar ‘add_filter’ line under it instead of creating the entire function twice.

Ok, thank you!

I think I triggered the same bug. In testing I wrote this code:

php
function something() {
echo 'foo';
}

function something() {
echo 'bar';
}

When into mysql and this is what was saved to the DB:

a:1:{s:26:"anarcho_cfunctions-content";s:126:"/* Enter Your Custom Functions Here */

function something() {
echo 'foo';
}

function something() {
echo 'bar';
}

";}

No the problem is it’s whitescreening the site… if as the aobve user did I renamed the plugin to disable it the site comes back, but then as soon as I enable the plugin it goes back to whitescreen. The _only_ way to fix this is to delete/fix the DB entry.

Suggestion:
Separate plugin activation from code being active. A few plugin do this now where you can activate the plugin, but the actual functionality is disabled until a checkbox is ticked. Then you could force that checkbox off on plugin activation/-reactivation in case of this scenario.

In your example you using two functions with the same name “something” and it raises an error. I’m trying to add a function to checking for similar function names but so far I can’t solve this.

Thank you for your suggestion!

I haven’t looked at your code (I’d just grabbed it for a demo I did for my meetup group as an alternative to adding code to functions.php) so I don’t know how and what exactly your checking, guessing though it’s just a basic syntax check.

My expectation was the code got run through a validator/linter. Writing two duplicate function names seemed like the easiest way to test it…

Even if I don’t like the idea of storing php in the DB where it needs to be queried and has higher than normal potential of being hacked by a MySQL injection… the plugin has a good use case I hope you get it worked out.

Yes, the plugin have just a basic syntax checker. Maybe you advise some validator/linter for using it in the plugin?

I was have choosing between storing php in the DB or in the file. You think storing php in the file is better?