Several issues/suggestions for version 1.5.x

Thanks for the suggestions. Are you running the current version, 1.5.1?

There’s already tickets for some:

7. https://github.com/bmarshall511/wordpress-zero-spam/issues/89
6. https://github.com/bmarshall511/wordpress-zero-spam/issues/90
5. https://github.com/bmarshall511/wordpress-zero-spam/issues/91

I’ll look into 4.

3 is currently in development: https://github.com/bmarshall511/wordpress-zero-spam/issues/85

Can’t reproduce 1 or 2. Can you shoot me to url and a login so I can look into those? You can send me an email at [email protected]

Thanks for the follow up. Site will send an invite shortly.

Yes, we’re running 1.5.1.

#3) I am not sure the issue you linked is 100% on point. The site is a subdomain on a network that is mapped to its own domain. The plugin is activated on that site, not network activated, so any settings should be specific to that site. Other URL’s that WP generates for the site use its mapped domain, not the network domain. A look at that issue leads me to believe it is about network activating and getting the settings down to a site.

Since reporting, site admin manually cleared the logs, so the data isn’t the same as the initial post.

Let me know if you need more.

v1.5.2 was just release which takes care of 7, 5 and if you wouldn’t mind verifying 3 is still an issue.

BTW, never did get the email with login info.

Will check out the update.

Just resent the email. It is an activation email from a site on our network.

Deactivated 1.5.1. Updated to 1.5.2. Activated 1.5.2. Reset log.

With 1.5.2 installed, here’s what we saw:

#3 (using wrong domain on multisite): Wrong domain still shows up.
#5 (log pagination): Works nicely. Thanks for the improvement.
#7 (use WP time, not server time): Still not working.

We’ll send you a private email since it looks like you haven’t activated your user account.

Re:#3 – the url for sub site activation comes from admin_url() this hasn’t changed from the v1.5. It’s just that now the plugin detects if it’s network activated and uses network_admin_url() instead.

Does anyone know how a mapped domain correctly deals with admin_url()?

It may be that with mapped domains network activation is necessary.

I’ve done a quick search and it seems that mapped domains want to use home_url() instead of admin_url()

Now the question is, how do we reliably detect when a mapped domain is present?

Take this for what it’s worth, since I only spent a few minutes looking at the code, but …

Isn’t the spam URL grabbed from _get_url() around line 1195 of zero-spam.class.php?

Isn’t this due to using $_SERVER[“SERVER_NAME”]?

For example, changing this:

$pageURL .= $_SERVER[“SERVER_NAME”] . $_SERVER[“REQUEST_URI”];

to:

$pageURL = site_url() . $_SERVER[“REQUEST_URI”];

grabs the right domain. However, it’s still missing the rest of the URL on which the spam comment originated.

Note that function builds the protocol, but that’s already in site_url() so I changed .= to just = for simplicity/illustration.

Hope that helps.

I think I fixed the domain mapping issue with https://github.com/bmarshall511/wordpress-zero-spam/pull/100

Time will tell. Keep us informed please.

That pull request doesn’t seem to relate to the logged URL where the spam came from. ie the spam URL. Admin URL’s seemed to work fine in 1.5.2. My comment only had to do with logged URLs.

The spam URL that’s logged seems to come from the code referenced in my previous comment.

If you want to log the correct URL in multisite, you need to use:

$_SERVER[“HTTP_HOST”]

instead of:

$_SERVER[“SERVER_NAME”]

We’ve tested both of the changes suggested in my comments, and they work.

Hope that helps.

Do all other links work with domain mapping?

If you mean other links in Zero Spam, such as the admin links, I would say yes, they work in 1.5.2 (without your pull request) and seemed to work in 1.5.0.

I gave Ben an invite as a site admin so he could confirm that.

Good. The PR will still be beneficial as it modularizes the specific code from afmin_url