Better WP Security conflict?

Where is the error thrown? What line/functions? Do you get an error message when you view the tree in wp admin?

Notice: Trying to get property of non-object in $templatepath$/wp-includes/author-template.php on line 74

The treeview is stuck on loading… and the error is thrown in the middle of two posts:

$templatepath$ is just a placeholder in my answer
____

“modified_author”: “Sanna Nellmer”,
“columns”: “”,
“user_can_edit_page”: “1”,
“user_can_add_page_inside”: “1”,
“user_can_add_page_after”: “1”,
“post_title”: “Sannas Test”
}
}
,
Notice: Trying to get property of non-object in $templatepath$/wp-includes/author-template.php on line 74
{
“data”: {
“title”: “Hans testsida 88”,
“attr”: {

____

I’ve got the same problem and have traced it a little further. I think it has to do with deleted users in general and not just the first user. The problem appears to be in core.

/wp-includes/author-template.php – line 73:

$last_user = get_userdata($last_id);

In my case $last_id is 4 which is a user that was deleted. The next line never checks if get_userdata() returns false and blindly uses a property on it. I’ve patched my local install by adding this to the CMS TPV functions file and changing line 1246 to use it instead.

function cms_tpv_get_the_modified_author() {
	if ( $last_id = get_post_meta( get_post()->ID, '_edit_last', true) ) {
		$last_user = get_userdata($last_id);
		if( $last_user !== false ){
			return apply_filters('the_modified_author', $last_user->display_name);
		}
	}
}

Yup. Sounds about right.
Is it possible to get this fixed for the next update of CMS TPV?

I’ve just updated to the latest version (1.2.13) and still getting this conflict error – CMS TPV is hanging and just shows the loading symbol.

It’s kicking out this error on the dashboard – Uncaught SyntaxError: Unexpected token <

When inspecting that further it’s showing this error – <b>Notice</b>: Trying to get property of non-object in <b>/var/www/vhosts/DOMAIN.COM/httpdocs/wp-includes/author-template.php</b> on line <b>74</b>

Is there anything else you can do to fix? CMS TPV is a great plugin and definitely a life-saver when it comes to managing the website, so would really like to have this fixed!

Thanks

Thanks for all the debugging folks! I should be able to fix this now. However you have to wait a while because the computer where the code is on is broken and I’m waiting for it to be fixed.

OK, my computer is back on track and I’m to release a new version of this plugin today. @chris: I used your function cms_tpv_get_the_modified_author() to fix the author issue, hope you’re fine with that ??

Thanks @p?r, glad it worked!