I found a problem on Simple Local Avatars 2.0

2.0 has an issue on line 64 where the argument for $id_or_email is missing.

public function get_avatar( $avatar = ”, $id_or_email, $size = 96, $default = ”, $alt = ” )

should be : public function get_avatar( $avatar = ”, $id_or_email = ”, $size = 96, $default = ”, $alt = ” )

^^^ this fixes it thanks!

Thanks for the fix!

With the fix, it’s top !

Thanks

I also discovered this bug, but went a little further to find the reason it was happening in the first place.

The static function get_simple_local_avatar() calls the class function Simple_Local_Avatars::get_avatar(). Because the plugin also puts a filter calling this function on the WP action ‘get_avatar’ the filter has to be suspended first. However, it was done incorrectly…instead of “remove_filter” “remove_action” was used, so the filter remains in place and the wrong function gets called. Here’s how I fixed it:

Old Code in file “simple-local-avatars.php” on line 536:

if ( empty ( $avatar ) ) {
    remove_action( 'get_avatar', array( $simple_local_avatars, 'get_avatar' ));
    $avatar = get_avatar( $id_or_email, $size, $default, $alt );
    add_action( 'get_avatar', array( $simple_local_avatars, 'get_avatar' ) );
}

New Code:

if ( empty ( $avatar ) ) {
    remove_filter( 'get_avatar', array( $simple_local_avatars, 'get_avatar' ), 10 );
    $avatar = get_avatar( $id_or_email, $size, $default, $alt );
    add_filter( 'get_avatar', array( $simple_local_avatars, 'get_avatar' ), 10, 5 );
}

@xnau that didn’t fix the issue for me. setting a default argument for $id_or_email in the get_avatar() function as mentioned by @draiz however, did.